Skip to content

Commit 1f259d8

Browse files
maartenbakhalidabuhakmeh
authored andcommitted
Fix PR comment
1 parent 4d1fb55 commit 1f259d8

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

src/content/docs/identityserver/ui/login/dynamicproviders.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -233,14 +233,14 @@ builder.Services.ConfigureOptions<CustomConfig>();
233233
```
234234

235235
:::note
236-
In your `IConfigureNamedOptions<OpenIdConnectOptions>`, you can use constructor injection to access other services.
237-
Beware of performance, for example when accessing your Entity Framework Core database context here.
238-
We recommend caching any additional data you may need as part of configuring options.
239-
240-
Note that the `OidcProvider` class has a `Properties` bag that can be used to store additional dynamic identity provider
241-
configuration data you could use to further customize the `OpenIdConnectOptions`. When you require this (or other) data
242-
from the `IIdentityProvider` store, you can use the `ConfigureAuthenticationOptions<>` base class to further customize
243-
your dynamic identity provider, as we'll see in the next section.
236+
While you can use constructor injection in your `IConfigureNamedOptions<OpenIdConnectOptions>` to access other services,
237+
we recommend using that technique sparingly for performance reasons. If you do need to access your Entity Framework Core
238+
database context here, make sure to cache any additional data you may need as part of configuring options.
239+
240+
Alternatively, the `OidcProvider` class has a `Properties` bag that can be used to store additional dynamic identity provider
241+
configuration data. You can use this data to further customize the `OpenIdConnectOptions`, instead of making additional database
242+
calls. When you require access to the `Properties` bag or the `IIdentityProvider` store, you can use the `ConfigureAuthenticationOptions<>`
243+
base class to further customize your dynamic identity provider, as we'll see in the next section.
244244
:::
245245

246246
### Accessing OidcProvider Data In IConfigureNamedOptions

0 commit comments

Comments
 (0)