use TokenClientCredentialStyle for PAR requests#351
Merged
Conversation
PushAuthorizationRequestAsync was not using the configured TokenClientCredentialStyle, causing PAR requests to potentially use a different credential style than token and refresh requests. Fixes #349
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a mismatch in client authentication style used for Pushed Authorization Requests (PAR) vs token/refresh requests in Duende.IdentityModel.OidcClient, aligning PAR with the configured OidcClientOptions.TokenClientCredentialStyle (per issue #349 / RFC 9126 expectations).
Changes:
- Apply
OidcClientOptions.TokenClientCredentialStyleto PAR requests inAuthorizeClient. - Expand tests to validate PAR client authentication for both
PostBody(default) andAuthorizationHeaderstyles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| identity-model-oidc-client/src/IdentityModel.OidcClient/AuthorizeClient.cs | Ensures PAR uses the same configured client credential style as token/refresh requests. |
| identity-model-oidc-client/test/IdentityModel.OidcClient.Tests/CodeFlowResponseTests.cs | Adds/updates tests to assert PAR credentials are sent via body vs Basic auth header depending on configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bhazen
approved these changes
Apr 12, 2026
damianh
added
the
area/foss/im-oidc-client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PushAuthorizationRequestAsyncwas not using the configuredTokenClientCredentialStyle, causing PAR requests to potentially use a different credential style than token and refresh requests.Fixes #349