Skip to content

Use sandbox mode which is more robust in singularity cleanup phase #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julianmorillo wants to merge 10 commits into
base: main
Choose a base branch
from
+16 −3
Open

Use sandbox mode which is more robust in singularity cleanup phase #193

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a69b4e6
Use sandbox mode which is more robust in singularity cleanup phase
julianmorillo Mar 26, 2026
47406ac
Now with correct bash syntax
julianmorillo Mar 26, 2026
149dfaf
Now with the singularity build command in place
julianmorillo Mar 26, 2026
46d3725
Merge branch 'main' into build-sandbox
julianmorillo Mar 31, 2026
d06e00f
Make the use of sandbox optional through an environment variable
julianmorillo Mar 31, 2026
8cd8dc7
Merge branch 'main' into build-sandbox
julianmorillo Apr 7, 2026
bfb6e27
Merge branch 'main' into build-sandbox
julianmorillo Apr 9, 2026
2f11ce2
Add --force to avoid error if sandbox build target already exists
julianmorillo Apr 9, 2026
69cc7fa
Merge branch 'build-sandbox' of github.com:julianmorillo/software-lay…
julianmorillo Apr 9, 2026
78cba78
Add the "--force" also to the echo to be consistent
julianmorillo Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions eessi_container.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,10 +1039,23 @@ for arg in "${PASS_THROUGH[@]}"; do
ADDITIONAL_CONTAINER_OPTIONS+=(${arg})
done

echo "Launching container with command (next line):"
echo "singularity ${RUN_QUIET} ${MODE} ${ADDITIONAL_CONTAINER_OPTIONS[@]} ${EESSI_FUSE_MOUNTS[@]} ${CONTAINER} $@"
singularity ${RUN_QUIET} ${MODE} "${ADDITIONAL_CONTAINER_OPTIONS[@]}" "${EESSI_FUSE_MOUNTS[@]}" ${CONTAINER} "$@"
# EESSI_SINGULARITY_SANDBOX is an environment variable (typically set in site_config.sh, if needed)
if [[ -n "$EESSI_SINGULARITY_SANDBOX" ]]; then
# using a sandbox image mode is more robust at the cleanup phase at the end
CONTAINER_SANDBOX="${CONTAINER%.sif}.sandbox"
echo "Building a sandbox image with command (next line):"
echo "singularity build --sandbox --force ${CONTAINER_SANDBOX} ${CONTAINER}"
singularity build --sandbox --force ${CONTAINER_SANDBOX} ${CONTAINER}
echo "Launching sandbox container with command (next line):"
echo "singularity ${RUN_QUIET} ${MODE} ${ADDITIONAL_CONTAINER_OPTIONS[@]} ${EESSI_FUSE_MOUNTS[@]} ${CONTAINER_SANDBOX} $@"
singularity ${RUN_QUIET} ${MODE} "${ADDITIONAL_CONTAINER_OPTIONS[@]}" "${EESSI_FUSE_MOUNTS[@]}" ${CONTAINER_SANDBOX} "$@"
exit_code=$?
else
echo "Launching container with command (next line):"
echo "singularity ${RUN_QUIET} ${MODE} ${ADDITIONAL_CONTAINER_OPTIONS[@]} ${EESSI_FUSE_MOUNTS[@]} ${CONTAINER} $@"
singularity ${RUN_QUIET} ${MODE} "${ADDITIONAL_CONTAINER_OPTIONS[@]}" "${EESSI_FUSE_MOUNTS[@]}" ${CONTAINER} "$@"
exit_code=$?
fi

# 6. save tmp if requested (arg -s|--save)
if [[ ! -z ${SAVE} ]]; then
Expand Down