Skip to content

"resolved-1971-1976" #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MallanagoudaB wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

"resolved-1971-1976" #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d32b33
"resolved-1971-1976"
MallanagoudaB Oct 17, 2024
790c0f3
"added-Success"
MallanagoudaB Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/controllers/v1/entityTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ module.exports = class EntityTypes extends Abstract {
const newEntityTypeData = await entityTypesHelper.bulkCreate(entityTypesCSVData, req.userDetails)

// Check if entity types were created successfully
if (newEntityTypeData.length > 0) {
if (newEntityTypeData.length > 0 && newEntityTypeData[0].status === CONSTANTS.apiResponses.SUCCESS) {
const fileName = `EntityType-Upload`
let fileStream = new FileStream(fileName)
let input = fileStream.initStream()
Expand All @@ -263,7 +263,9 @@ module.exports = class EntityTypes extends Abstract {

input.push(null)
} else {
throw CONSTANTS.apiResponses.PROJECT_FAILED
const error = new Error(CONSTANTS.apiResponses.PROJECT_FAILED)
error.status = HTTP_STATUS_CODE.bad_request.status
throw error
}
} catch (error) {
return reject({
Expand Down
2 changes: 1 addition & 1 deletion src/module/entities/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ module.exports = class UserProjectsHelper {
new: true,
}
)
await this.mappedParentEntities(updatedParentEntity, childEntity)
// await this.mappedParentEntities(updatedParentEntity, childEntity)
Copy link
Copy Markdown
Collaborator

@VISHNUDAS-tunerlabs VISHNUDAS-tunerlabs Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MallanagoudaB Please explain why this is commented

Copy link
Copy Markdown
Collaborator Author

@MallanagoudaB MallanagoudaB Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was mapping to all the entities.
Example: if we map to karnataka a school it was mapping to all other entities (Assam, Tamil Nadu)

Copy link
Copy Markdown
Collaborator

@VISHNUDAS-tunerlabs VISHNUDAS-tunerlabs Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MallanagoudaB if you comment this how the karanataka school mapping work?

Copy link
Copy Markdown
Collaborator Author

@MallanagoudaB MallanagoudaB Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has been done already in previous code i verified that.

}

return resolve()
Expand Down