b4b: Work on build-namelist Initial Condition file (finidat) picking#3842
Draft
ekluzek wants to merge 3 commits intoESCOMP:b4b-devfrom
Draft
b4b: Work on build-namelist Initial Condition file (finidat) picking#3842ekluzek wants to merge 3 commits intoESCOMP:b4b-devfrom
ekluzek wants to merge 3 commits intoESCOMP:b4b-devfrom
Conversation
…p_logic_initial_condition subroutine a few times and elsewhere to get the current use_init_interp setting in order to make the initial_conditions picking more robust working on issue ESCOMP#2169 and resolving ESCOMP#3832
Some final namelist default changes needed Some important final answer changes needed for the coupled model to get the right parameter file and to set n_melt_glcmec=1 for clm6_0. Also use the 2015 finidat file for SSP future scenarios. And fix some of the namelist picking for finidat files, especially for: 2003, 2010, and 2015. Conflicts: bld/CLMBuildNamelist.pm
ekluzek
added
enhancement
github-project-automation
bot
moved this to Ready to start (or start again)
in CTSM: Upcoming tags
ekluzek
added
the
blocked: dependency
Contributor
Author
|
This is blocked by needing ctsm5.4.027 to come to b4b-dev first. |
ekluzek
moved this from Ready to start (or start again)
to In progress - b4b-dev
in CTSM: Upcoming tags
ekluzek
changed the title
ekluzek
commented
Apr 8, 2026
|
|
||
| NOTE: And they need to be coordinated with clm_start_type that's in namelist_defaults_overall.xml | ||
|
|
||
| Find Initial condition files: The settings use_init_interp, init_interp_attributes and finidat MUST allundef; |
Contributor
Author
There was a problem hiding this comment.
Looks like these changes should be in here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Some work on the initial condition picking in build-namelist. This makes it more robust by making sure use_init_interp is set in nl_flags as strictly either .true. or .false. so it can be used correctly in getting values from namelist-defaults.
Part of what is happening here is that a new subroutine to set the current iteration of use_init_interp is added
setup_preliminary_use_init_interp
which is called a few different places and called more than once. So it makes the handling of use_init_interp as it plays out to be more robust.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #3832
Work on #2169
Are answers expected to change (and if so in what way)? No, unless there is a bug in finidat picking
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No No
Testing performed, if any: will do regular