Skip to content

Add delete route for map groups and refine existing group URLs #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pollardld merged 1 commit into from
May 28, 2026
Merged

Add delete route for map groups and refine existing group URLs #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions wcoa/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,12 @@
re_path(r'^collaborate/groups/(?P<pk>\d+)/promote/?', groupviews.PromoteMapGroupMemberActionView.as_view(), name='promote-member'),
re_path(r'^collaborate/groups/(?P<pk>\d+)/demote/?', groupviews.DemoteMapGroupMemberActionView.as_view(), name='demote-member'),
re_path(r'^collaborate/groups/(?P<pk>\d+)/remove/?', groupviews.RemoveMapGroupMemberActionView.as_view(), name='remove-member'),
re_path(r'^collaborate/groups/?(?P<pk>\d+)/(?P<slug>[\w-]+)/delete/?$', groupviews.DeleteMapGroupActionView.as_view(), name='delete'),
re_path(r'^collaborate/groups/?(?P<pk>\d+)/(?P<slug>[\w-]+)/edit/?', views.show_wcoa_edit_mapgroups, name='edit'),
re_path(r'^collaborate/groups/?(?P<pk>\d+)/(?P<slug>[\w-]+)/preferences/?$', MapGroupPreferencesView.as_view(), name='preferences'),
re_path(r'^collaborate/groups/?(?P<pk>\d+)/(?P<slug>[\w-]+)/?$', views.show_wcoa_detail_mapgroups, name='detail'),
Comment on lines +34 to 37
re_path(r'^collaborate/groups/?', views.show_wcoa_mapgroups, name='show_wcoa_mapgroups'),
re_path(r'^groups/?', views.show_wcoa_mapgroups, name='show_wcoa_mapgroups'),
re_path(r'^collaborate/groups/?$', views.show_wcoa_mapgroups, name='show_wcoa_mapgroups'),
Copy link
Copy Markdown
Member

@rhodges rhodges May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a strong need to enforce URL end here with $? I can see tradeoffs with adding it:

  • Pro: potential future URL flow confusion can be avoided, especially highlighting typos
  • Con: less elegant failure - goes to error instead of failing gracefully back to the (collaborate/)groups/page.

Copy link
Copy Markdown
Member

@rhodges rhodges May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I see how this interplays with the new line you added: if the PK or the slug does not exist, then the DELETE API instead might return someone (depending on how mismatches are handled) to the Groups page without an error. I can see that being confusing

re_path(r'^groups/?$', views.show_wcoa_mapgroups, name='show_wcoa_mapgroups'),
re_path(r'^groups/(?P<pk>\d+)/(?P<slug>[\w-]+)/edit/?', views.show_wcoa_edit_mapgroups, name='edit'),
re_path(
"choose-newtab-link/",
Expand Down