Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
# Package managers:
node_modules/
npm-debug.log
package-lock.json
yarn-error.log

# Editors:
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
legacy-peer-deps=true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Agentic Security Review
Severity: HIGH

The npm migration removed the previous install-script hardening (--ignore-scripts true in Yarn) without adding the npm equivalent. As a result, lifecycle scripts from third-party/transitive packages will run automatically during dependency install.

This creates a supply-chain execution boundary regression: a compromised dependency can execute commands in CI/dev install contexts and potentially access environment secrets or alter build outputs.

Fix in Cursor Fix in Web

Reviewed by Cursor Security Reviewer for commit 86b6c4f. Configure here.

2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ language: node_js
node_js:
- 18
script:
- yarn verify
- npm run verify
1 change: 0 additions & 1 deletion .yarnrc

This file was deleted.

4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ The bundle located in `dist/edge-currency-plugins.js` will automatically registe
<script src='https://example.com/app/dist/edge-currency-plugins.js'>
```

If you want to debug this project, run `yarn start` to start a Webpack server,
If you want to debug this project, run `npm run start` to start a Webpack server,
and then adjust your script URL to http://localhost:8084/edge-currency-plugins.js.

### React Native
Expand All @@ -59,7 +59,7 @@ import { pluginUri, makePluginIo } from "edge-currency-plugins";
/>;
```

To debug this project, run `yarn start` to start a Webpack server, and then use `debugUri` instead of `pluginUri`.
To debug this project, run `npm run start` to start a Webpack server, and then use `debugUri` instead of `pluginUri`.

## How to Contribute

Expand Down
2 changes: 1 addition & 1 deletion docs/currency-integration.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ sorting when placing the new currency plugin info in the `all` object.

### 3. Test the new currency plugin

Run the Webpack dev-server with `yarn start` and leverage the `debugUri` in
Run the Webpack dev-server with `npm run start` and leverage the `debugUri` in
your application to quickly iterate while debugging/developing.

### 4. Submit a pull request
Expand Down
Loading
Loading