-
Notifications
You must be signed in to change notification settings - Fork 18
Convert to npm #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peachbits
wants to merge
6
commits into
master
Choose a base branch
from
convert-to-npm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Convert to npm #449
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
db120c4
Convert from yarn to npm
298af98
Apply Socket-recommended security upgrades
peachbits e89b4ef
Apply major version Socket-recommended security upgrades
peachbits 332e586
Pin get-func-name to 2.0.2 so chai loads under mocha (fixes ERR_UNKNO…
j0ntz 86b6c4f
fixup! Convert from yarn to npm
14d276a
fixup! Apply Socket-recommended security upgrades
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,6 @@ | |
| # Package managers: | ||
| node_modules/ | ||
| npm-debug.log | ||
| package-lock.json | ||
| yarn-error.log | ||
|
|
||
| # Editors: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| legacy-peer-deps=true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,4 @@ language: node_js | |
| node_js: | ||
| - 18 | ||
| script: | ||
| - yarn verify | ||
| - npm run verify | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Agentic Security Review
Severity: HIGH
The npm migration removed the previous install-script hardening (
--ignore-scripts truein Yarn) without adding the npm equivalent. As a result, lifecycle scripts from third-party/transitive packages will run automatically during dependency install.This creates a supply-chain execution boundary regression: a compromised dependency can execute commands in CI/dev install contexts and potentially access environment secrets or alter build outputs.
Reviewed by Cursor Security Reviewer for commit 86b6c4f. Configure here.