Add MSBuild workflow for CI/CD#9184
Open
nsabedra27-glitch wants to merge 1 commit into
Open
Conversation
This workflow automates the build process using MSBuild on push and pull request events for the master branch.
Andezion
requested changes
Jul 21, 2026
Andezion
left a comment
Collaborator
There was a problem hiding this comment.
Core-lightning built via the custom configurator/waf-based build system (see ccan/config.h, configurator.out in the working tree) - there is no .sln file and no MSBuild/.NET tooling anywhere in this repo. This workflow will fail on the very first step - no NuGet packages or project files exist and no solution file to build. What is this workflow meant to build? There's no indication the project has an MSBuild-based component
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Add MSBuild to PATH | ||
| uses: microsoft/setup-msbuild@v1.0.2 |
Collaborator
There was a problem hiding this comment.
Irrelevant cost/runtime for a project that has nothing to do with Windows/.NET builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow automates the build process using MSBuild on push and pull request events for the master branch.
Important
26.06 FREEZE April 30th: Non-bugfix PRs not ready by this date will wait for 26.09.
RC1 is scheduled on May 14th
The final release is scheduled for June 1st.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade