Open
Conversation
…ifier rather than the ROM offset of the location table entry.
TheRealQuantam
requested review from
Ellendar,
initsu and
jroweboy
and removed request for
initsu
Collaborator
Author
|
After fixing stupid bug I generated 10 seeds on beginner and 10 on max rando before and after this PR and they came out identical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR significantly cleans up the way locations are referenced by adding a LocationID enum and switching older methods (like ROM offsets to location table entries) to use the new method. It also removes some hard-coded location lists, replacing them with programmatic generation from the ROM.
Initial implementation is finished. I have not yet tested it apart from verifying it can generate a ROM. I figured reviewers would want to look it over carefully as both design and implementation are subject to feedback, so review can happen while I test it (and if anyone else wants to test it feel free). When reviewing, extra attention should be given to whether some of the removal of old things is safe with how shuffling works, and I didn't cut too deep.
Do NOT merge until review and testing are complete.