Annotate locale-engine fork (mark [fork] changes, neutral naming)#390
Open
labrie75 wants to merge 1 commit into
Open
Annotate locale-engine fork (mark [fork] changes, neutral naming)#390labrie75 wants to merge 1 commit into
labrie75 wants to merge 1 commit into
Conversation
Annotate the localization fork; restore upstream-identical lines
Make this fork's delta vs upstream explicit and minimal:
- Restore lines we had incidentally changed so the diff shows only
intentional changes (separator widths; drop a stray inline comment).
- Mark every fork change inline:
* [fork] MODIFIED — Lf() now L()-translates each argument so a label
passed as %s renders localized (upstream original kept in a comment).
* [fork] ADDED — language-neutral blocks not in upstream:
- reverse-format engine (localize format()/concat strings from the catalog)
- render-boundary hooks (FontString/Button:SetText, SetFormattedText,
tooltip line pools, EUI StaticPopup) with 12.0 secret-value/taint guards
- localized tooltip-line parser (Item Upgrade Calculator, etc.)
- Rename the install flag to a locale-neutral name (_localeRenderHook).
The ADDED blocks translate at the render boundary for ANY active locale;
only Locales/koKR.lua is Korean-specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotate the localization fork; restore upstream-identical lines Make this fork's delta vs upstream explicit and minimal: