Add tooltip behavior options#393
Open
foxyybb wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Just wanted to comment with some updates; I have been running BugGrabber etc and haven't had any Lua errors from this yet. I've been fixing bugs as I find them, but I haven't checked areas like garrisons yet. One thing I've noted that I am uncertain if it's related to this change or something else entirely is my camera occasionally locks during lag. I thiiink this was happening previous to these changes and is related to MouselookStart() and MouselookStop() events being missed during hangs which I've been finding happen a fair bit during buffs in raid. If I find the time I'll see if there's any open issues that can be resolved on that front :) I LOVE the work you've done with EUI, tysm for continuing to support the work <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds cursor anchoring, tooltip fade options, as well as chat tooltip hover options. The fading is something that I think is a bit finicky since the time it's based on is how long prior to beginning to fade rather than the actual fade timing. Everything was working locally on my end, but I have not tested every option combination so I may have missed something... please let me know if you have thoughts :)
Worth noting, LLMs were used in generating a good chunk of this code and ensuring that standards were followed within the code base.