Skip to content

fix(strata): render overlaid elements above their borders#424

Merged
EllesmereGaming merged 2 commits into
EllesmereGaming:mainfrom
nulltyto:bugfix/8.2.6-strata-fixes
Jun 22, 2026
Merged

fix(strata): render overlaid elements above their borders#424
EllesmereGaming merged 2 commits into
EllesmereGaming:mainfrom
nulltyto:bugfix/8.2.6-strata-fixes

Conversation

@nulltyto

Copy link
Copy Markdown
Contributor

Summary

Fixes a class of layering bug where overlaid elements rendered beneath their frame's border (or below the bars) because they sat at a lower frame level / strata than the overlapping border. Each is raised above its border (or, where the border should win, ordered deliberately).

Bug reports

Fixes

  • DK rune cooldown number — countdown text now clears the outer bar border. (Rune pips use per-pip border size 0, so the visible border is secondaryFrame._barBorder at +5; the number was below it.)
  • Role icon & leader/assist crown (party/raid) — moved into the above-border/below-aura band (LVL_AURA - 1) in both the real and preview builders, so they clear the general border while auras still draw over them and the hover/target border raise still covers them. The leader crown was also taken off the chat strata on real frames (it was a lower strata than the frame, so it always drew under the border).
  • Group numbers (raid) — hosted on a high-level overlay so they draw over the bars instead of behind them (real + preview).
  • Targeted spells (party) — the spell icon and its border now sit below the health-text carrier so the health % stays readable when the icon is centered over it (border still above the icon).
  • Tracking bars — timer/name/stacks text overlay raised above the bar border (and pandemic glow). The options preview also gains vertical headroom so text positioned above/below the bar is no longer clipped by the scroll wrapper.
  • Damage meters — bar position/name/amount text raised above the lazily-created bar border.

Notes

  • Layering-only changes (frame level / strata / parent / draw order) — no behavioral or secure-frame changes, so they're combat-safe.
  • Verified in-client: runes, role/leader icons (live + preview), group numbers (live + preview), targeted spells, tracking bars + options preview, and damage meters with borders enabled.

nulltyto added 2 commits June 21, 2026 13:28
Several elements rendered beneath the border frame (or below the bars)
because they sat at a lower frame level/strata than the overlapping
border. Raise each above its border:

- Resource bars: DK rune countdown number now clears the outer bar
  border (runes use per-pip border size 0, so the visible border is
  secondaryFrame._barBorder at +5).
- Raid frames: role icon and leader/assist crown moved into the
  above-border/below-aura band (LVL_AURA-1) in both real and preview
  builders; leader crown taken off the chat strata (real frames).
  Group-number labels hosted on a high-level overlay so they draw over
  the bars (real + preview).
- Targeted spells: icon + its border dropped below the health-text
  carrier so the health % stays readable when overlapping (border still
  above the icon).
- Tracking bars: timer/name/stacks text overlay raised above the bar
  border (and pandemic glow). Options preview gains vertical headroom so
  top/bottom text is no longer clipped by the scroll wrapper.
- Damage meters: bar text raised above the lazily-created bar border.
Pre-existing drift on the v8.2.6 base (Buff Bar -> Delete Spell); the
strata changes touch no L() strings. Regenerated via
.tools/extract-locale-keys.sh to satisfy the locale-check CI.
@EllesmereGaming EllesmereGaming merged commit f2372d9 into EllesmereGaming:main Jun 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants