fix(strata): render overlaid elements above their borders#424
Merged
EllesmereGaming merged 2 commits intoJun 22, 2026
Merged
Conversation
Several elements rendered beneath the border frame (or below the bars) because they sat at a lower frame level/strata than the overlapping border. Raise each above its border: - Resource bars: DK rune countdown number now clears the outer bar border (runes use per-pip border size 0, so the visible border is secondaryFrame._barBorder at +5). - Raid frames: role icon and leader/assist crown moved into the above-border/below-aura band (LVL_AURA-1) in both real and preview builders; leader crown taken off the chat strata (real frames). Group-number labels hosted on a high-level overlay so they draw over the bars (real + preview). - Targeted spells: icon + its border dropped below the health-text carrier so the health % stays readable when overlapping (border still above the icon). - Tracking bars: timer/name/stacks text overlay raised above the bar border (and pandemic glow). Options preview gains vertical headroom so top/bottom text is no longer clipped by the scroll wrapper. - Damage meters: bar text raised above the lazily-created bar border.
Pre-existing drift on the v8.2.6 base (Buff Bar -> Delete Spell); the strata changes touch no L() strings. Regenerated via .tools/extract-locale-keys.sh to satisfy the locale-check CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a class of layering bug where overlaid elements rendered beneath their frame's border (or below the bars) because they sat at a lower frame level / strata than the overlapping border. Each is raised above its border (or, where the border should win, ordered deliberately).
Bug reports
Fixes
secondaryFrame._barBorderat +5; the number was below it.)LVL_AURA - 1) in both the real and preview builders, so they clear the general border while auras still draw over them and the hover/target border raise still covers them. The leader crown was also taken off the chat strata on real frames (it was a lower strata than the frame, so it always drew under the border).Notes