[CastBars] new per-state colour pickers ("Color", "Channeling Color", and "Uninterruptible Color"); some bug fixes#434
Open
maxzaleski wants to merge 2 commits into
Open
Conversation
…w state dropdown Split the single cast bar fill-colour picker into three per-state pickers: Color (default), Channeling Color, and Uninterruptible Color. Each picker uses the same three-swatch layout (Gradient End, Custom Coloured, Class Coloured) and has its own gradient cog (Enable Gradient + direction). Uninterruptible takes priority over Channeling at runtime. Added a Color / Channeling / Uninterruptible dropdown to the preview widget header so each cast state can be previewed independently. Preview now correctly resolves the current selection (custom, class, gradient) on first render. Per-state DB keys (channelFillR/G/B/A, channelGradientR/G/B/A, channelClassColored, channelGradientEnabled, channelGradientDir, and uninterrupt* equivalents) default to nil and fall back to the base keys, so existing profiles are visually unchanged.
…in combat GetStatusBarTexture() returns nil when the StatusBar value is 0 and the frame has never been rendered (TWW behaviour). Cache the texture reference in _fillTex immediately after SetStatusBarTexture in BuildCastBar, and use it in ApplyCastFillColor as the primary source, falling back to GetStatusBarTexture() for safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary Changes
"Uninterruptible Color"
(Enable Gradient + direction)
colour)
Note
UNIT_SPELLCAST_NOT_INTERRUPTIBLE/UNIT_SPELLCAST_INTERRUPTIBLEmid-cast events on the player's own bar, which is acceptable as player cast interruptibility changes are rare and the castbar resets on each new cast._empowering) fall through to the Default colour unless_notInterruptibleis also set.Bug Fixes
render; it only updated on change
Backwards Compatibility
No existing keys are renamed or removed. All new per-state keys default to nil and fall back to the base fillR/G/B/A,
gradientR/G/B/A, classColored, gradientEnabled,andgradientDirvalues. Existing profiles are visually unchanged until a per-state colour is explicitly set.Screenshots
Settings