-
Notifications
You must be signed in to change notification settings - Fork 0
π§ͺ Add unit tests for Labels string parsing #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rnovatorov
merged 4 commits into
main
from
testing-improvement-labels-parsing-6959259806670736819
Apr 1, 2026
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bdc04d9
π§ͺ Add unit tests for Labels string parsing and fix edge cases
google-labs-jules[bot] f953135
π§ͺ Remove unnecessary conftest.py mocking
google-labs-jules[bot] 0e5e55d
π§ͺ Simplify Labels.parse implementation
google-labs-jules[bot] 58595c5
π§ͺ Restore original Labels.parse implementation and update tests
google-labs-jules[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
27 changes: 27 additions & 0 deletions
27
tests/unit/test_http/test_api/test_telemetry/test_labels.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| from enapter.http.api.telemetry.labels import Labels | ||
|
|
||
|
|
||
| def test_parse_multiple_labels(): | ||
| s = "device=foo telemetry=bar custom=baz" | ||
| labels = Labels.parse(s) | ||
| assert labels == {"device": "foo", "telemetry": "bar", "custom": "baz"} | ||
| assert labels.device == "foo" | ||
| assert labels.telemetry == "bar" | ||
|
|
||
|
|
||
| def test_parse_single_label(): | ||
| s = "device=only" | ||
| labels = Labels.parse(s) | ||
| assert labels == {"device": "only"} | ||
| assert labels.device == "only" | ||
|
|
||
|
|
||
| def test_parse_empty_string(): | ||
| labels = Labels.parse("") | ||
| assert labels == {} | ||
|
|
||
|
|
||
| def test_parse_multiple_spaces(): | ||
| s = "device=foo telemetry=bar " | ||
| labels = Labels.parse(s) | ||
| assert labels == {"device": "foo", "telemetry": "bar"} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.