Li/verify cas

[lukeiannucci]

Closes #<ISSUE_NUMBER>

This PR:

This PR does not:

Key places to review:

[gemini-code-assist]

Code Review

This pull request renames L1-specific configuration fields and CLI flags to Ethereum-specific terminology (e.g., eth_rpc, EthRPC, wait_for_eth_finality) across the codebase, and introduces new end-to-end integration tests for the Chain Adjacent Service (CAS) with Nitro. It also refactors the proxy RPC compatibility checks into a shared helper function and updates dependencies. The review feedback highlights a style guide violation regarding inconsistent acronym capitalization for EthRpc (which should be EthRPC), and points out minor logging discrepancies in the newly added CAS E2E tests where the logged block number does not match the actual target block.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

espresso_e2e/cas_nitro_e2e_test.go (50)

There is a discrepancy between the log message and the actual target block being verified. The log message states it is waiting to advance past block 20, but the assertion on line 52 checks against targetBlock which is defined as 40. It is better to use targetBlock dynamically in the log message to avoid such inconsistencies.

	t.Logf("Waiting for CAS Nitro verifier to advance store past block %d", targetBlock)

espresso_e2e/cas_v3_10_nitro_e2e_test.go (50)

There is a discrepancy between the log message and the actual target block being verified. The log message states it is waiting to advance past block 20, but the assertion on line 52 checks against targetBlock which is defined as 40. It is better to use targetBlock dynamically in the log message to avoid such inconsistencies.

	t.Logf("Waiting for CAS Nitro verifier to advance store past block %d", targetBlock)

verifier/nitro/nitro_verifier.go (40)

According to the Go style guide (Go Code Review Comments), acronyms and initialisms should be consistently capitalized (e.g., EthRPC instead of EthRpc). This also aligns with FullNodeExecutionRPC and OPEspressoBatchVerifierConfig.EthRPC used elsewhere in the codebase.

	EthRPC                 string                 `json:"eth_rpc"`

References

1. Go Code Review Comments: Words in names that are initialisms or acronyms (e.g. RPC, URL) should have a consistent case. ^(link)

verifier/nitro/nitro_verifier.go (89-91)

Update references to use EthRPC instead of EthRpc to maintain consistent acronym capitalization.

	ethClient, err := ethclient.DialContext(ctx, config.EthRPC)
	if err != nil {
		logger.Crit("failed to dial Nitro eth RPC", "url", config.EthRPC, "error", err)

References

1. Go Code Review Comments: Words in names that are initialisms or acronyms (e.g. RPC, URL) should have a consistent case. ^(link)

config.go (267)

Update references to use EthRPC instead of EthRpc to maintain consistent acronym capitalization.

		EthRPC:                 c.EthRPC,

References

1. Go Code Review Comments: Words in names that are initialisms or acronyms (e.g. RPC, URL) should have a consistent case. ^(link)

espresso_e2e/cas_e2e_utils.go (41)

Update references to use EthRPC instead of EthRpc to maintain consistent acronym capitalization.

			EthRPC:               casL1URL,

References

1. Go Code Review Comments: Words in names that are initialisms or acronyms (e.g. RPC, URL) should have a consistent case. ^(link)

espresso_e2e/e2e_utils.go (140)

Update references to use EthRPC instead of EthRpc to maintain consistent acronym capitalization.

			EthRPC:               nitroL1URL,

References

1. Go Code Review Comments: Words in names that are initialisms or acronyms (e.g. RPC, URL) should have a consistent case. ^(link)