Skip to content

GH-401 Use already defined versions of plugins in runServer script#401

Closed
CitralFlo wants to merge 1 commit into
masterfrom
runserver-versions
Closed

GH-401 Use already defined versions of plugins in runServer script#401
CitralFlo wants to merge 1 commit into
masterfrom
runserver-versions

Conversation

@CitralFlo

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Michał Wojtas <wojtas.michal90@gmail.com>
@CitralFlo CitralFlo changed the title Use already defined versions of plugins in runServer script GH-401 Use already defined versions of plugins in runServer script Jun 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Gradle build configuration by externalizing hardcoded plugin versions in eternalcombat-runserver.gradle.kts to the Versions object in Versions.kt. The review feedback recommends reusing the existing WORLD_GUARD_BUKKIT constant instead of defining a duplicate WORLDGUARD constant to maintain a single source of truth.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +30 to +34
//runServer task
const val FAST_ASYNC_WORLD_EDIT = "2.15.2"
const val PACKETEVENTS = "2.12.2+spigot"
const val WORLDGUARD = "7.0.17"
const val LUCKPERMS = "v5.5.53-bukkit"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The constant WORLD_GUARD_BUKKIT is already defined with the value "7.0.17" on line 25. To avoid duplication and maintain a single source of truth, we should reuse WORLD_GUARD_BUKKIT instead of defining a new WORLDGUARD constant.

Suggested change
//runServer task
const val FAST_ASYNC_WORLD_EDIT = "2.15.2"
const val PACKETEVENTS = "2.12.2+spigot"
const val WORLDGUARD = "7.0.17"
const val LUCKPERMS = "v5.5.53-bukkit"
//runServer task
const val FAST_ASYNC_WORLD_EDIT = "2.15.2"
const val PACKETEVENTS = "2.12.2+spigot"
const val LUCKPERMS = "v5.5.53-bukkit"

downloadPlugins.modrinth("LuckPerms", "v5.5.53-bukkit")
downloadPlugins.modrinth("FastAsyncWorldEdit", Versions.FAST_ASYNC_WORLD_EDIT)
downloadPlugins.modrinth("PacketEvents", Versions.PACKETEVENTS)
downloadPlugins.modrinth("WorldGuard", Versions.WORLDGUARD)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use the already defined Versions.WORLD_GUARD_BUKKIT constant instead of the duplicate Versions.WORLDGUARD.

        downloadPlugins.modrinth("WorldGuard", Versions.WORLD_GUARD_BUKKIT)

@vLuckyyy

Copy link
Copy Markdown
Member

I don’t think we should use global variables here, since each plugin version is only used once across the entire project. Renovate doesn’t update these plugin versions either.

I’ve also noticed that we often change both the server version and the plugin versions while testing. Having to constantly go to Versions.kt just to update, for example, the FAWE version because the current one doesn’t support a newer Minecraft version has become inconvenient.

@vLuckyyy vLuckyyy closed this Jun 21, 2026
@vLuckyyy

Copy link
Copy Markdown
Member

In my opinion, this is one of those cases where aesthetics and consistency should take a back seat to convenience and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants