GH-401 Use already defined versions of plugins in runServer script#401
GH-401 Use already defined versions of plugins in runServer script#401CitralFlo wants to merge 1 commit into
Conversation
Signed-off-by: Michał Wojtas <wojtas.michal90@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request refactors the Gradle build configuration by externalizing hardcoded plugin versions in eternalcombat-runserver.gradle.kts to the Versions object in Versions.kt. The review feedback recommends reusing the existing WORLD_GUARD_BUKKIT constant instead of defining a duplicate WORLDGUARD constant to maintain a single source of truth.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| //runServer task | ||
| const val FAST_ASYNC_WORLD_EDIT = "2.15.2" | ||
| const val PACKETEVENTS = "2.12.2+spigot" | ||
| const val WORLDGUARD = "7.0.17" | ||
| const val LUCKPERMS = "v5.5.53-bukkit" |
There was a problem hiding this comment.
The constant WORLD_GUARD_BUKKIT is already defined with the value "7.0.17" on line 25. To avoid duplication and maintain a single source of truth, we should reuse WORLD_GUARD_BUKKIT instead of defining a new WORLDGUARD constant.
| //runServer task | |
| const val FAST_ASYNC_WORLD_EDIT = "2.15.2" | |
| const val PACKETEVENTS = "2.12.2+spigot" | |
| const val WORLDGUARD = "7.0.17" | |
| const val LUCKPERMS = "v5.5.53-bukkit" | |
| //runServer task | |
| const val FAST_ASYNC_WORLD_EDIT = "2.15.2" | |
| const val PACKETEVENTS = "2.12.2+spigot" | |
| const val LUCKPERMS = "v5.5.53-bukkit" |
| downloadPlugins.modrinth("LuckPerms", "v5.5.53-bukkit") | ||
| downloadPlugins.modrinth("FastAsyncWorldEdit", Versions.FAST_ASYNC_WORLD_EDIT) | ||
| downloadPlugins.modrinth("PacketEvents", Versions.PACKETEVENTS) | ||
| downloadPlugins.modrinth("WorldGuard", Versions.WORLDGUARD) |
|
I don’t think we should use global variables here, since each plugin version is only used once across the entire project. Renovate doesn’t update these plugin versions either. I’ve also noticed that we often change both the server version and the plugin versions while testing. Having to constantly go to |
|
In my opinion, this is one of those cases where aesthetics and consistency should take a back seat to convenience and maintainability. |
No description provided.