This repository was archived by the owner on Aug 14, 2020. It is now read-only.
Fix broken 'dovecot' git submodule dependencies#2
Merged
Conversation
1) Fetch EthACKdotOrg/dovecot for via HTTPS to avoid authenticity errors with some github.com ip addresses: ``` Cloning into 'puppet/modules/dovecot'... The authenticity of host 'github.com (192.30.252.128)' can't be established. RSA key fingerprint is 16:27:ac:a5:76:28:2d:36:63:1b:56:4d:eb:df:a6:48. Are you sure you want to continue connecting (yes/no)? ^C fogmail (master)$ Clone of 'git@github.com:EthACKdotOrg/dovecot.git' into submodule path 'puppet/modules/dovecot' failed ``` 2) Fix referred commit for EthACKdotOrg/dovecot (previous commit was probably squashed when feature branch was rebased for mjhas/dovecot#27
cjeanneret
added a commit
that referenced
this pull request
Dec 1, 2014
Fix broken 'dovecot' git submodule dependencies Thanks! For now, I'd rather use submodules in order to avoid more dependencies. Especially since it's not finished. Maybe later, once modules are fixed and stabilized (especially the one for xtreemfs, being developed with now). More over, the whole stuff will be scripted, especially the "storage" part, as anyone should be able to deploy that.
Contributor
|
Thanks! For now, I'd rather use submodules in order to avoid more dependencies. |
Contributor
Author
|
Ok, thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with some github.com ip addresses:
🍥 Bonus Question: are you open to switch to a puppet module dependency manager, instead of relying on git submodules? I am a total newbie in Puppet (but have some experience with Chef and Ansible CM tools) and with rapid internet search it seems to me that http://librarian-puppet.com/ would be a (the) good candidate.