feat: accessibility improvements — skip link, WCAG AA dark mode contrast, focus rings, ARIA live regions#832
Open
hman38705 wants to merge 1 commit into
Conversation
…real-Future#740, Ethereal-Future#741, Ethereal-Future#742 - Ethereal-Future#739 (skip link): skip-to-main-content link is already first in DOM with <main id="main-content"> target; fix skip-link color to use --on-primary token so it passes WCAG AA in both light and dark mode - Ethereal-Future#740 (dark mode contrast): replace hardcoded Ethereal-Future#555/Ethereal-Future#666 colors on .balance-asset, .qr-pubkey, and .sm-history-toggle with var(--muted) so they meet ≥4.5:1 contrast ratio on dark backgrounds; audit of all dark mode CSS custom property pairs confirms they all pass WCAG AA - Ethereal-Future#741 (focus-visible ring): add --focus-ring-color/width/offset tokens to :root; add --focus-ring-color override in .theme-dark (#93c5fd, 11.4:1); fix input:focus-visible to use ring tokens instead of outline:none; fix .fu-dropzone to use :focus-visible with ring instead of outline:none - Ethereal-Future#742 (live regions): balance display wrapped in role="status" aria-live region so updated balance is announced after transactions; StatusMessage now uses role="alert" for error/warning (assertive) and role="status" for success/info (polite), preventing disruptive interruptions for non-urgent notifications; loading state live region was already present Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@hman38705 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #739
closes #740
closes #741
closes #742
Implements all four Stellar Wave accessibility issues in a single PR.
#739 — Skip-to-main-content link
The skip link (
<a href="#main-content" className="skip-link">) was already rendered as the first DOM element inApp.jsx, and<main id="main-content">was already in place. This PR fixes the skip link'scolorfrom the hardcoded#ffftovar(--on-primary)so it remains WCAG-compliant in dark mode (#0f172aon#60a5fa→ 7.3:1 ✓).#740 — WCAG AA colour contrast in dark mode
Audit of
.theme-darkCSS custom property pairs:--text(#e2e8f0) on--bg(#020617)--muted(#94a3b8) on--bg(#020617)--muted(#94a3b8) on--surface(#111827)--muted(#94a3b8) on--card(#1f2937)--primary(#60a5fa) on--bg(#020617)--on-primary(#0f172a) on--primary(#60a5fa)--danger(#f87171) on--bg(#020617)--danger(#f87171) on--card(#1f2937)--success(#34d399) on--bg(#020617)--warning(#fbbf24) on--bg(#020617)--info(#38bdf8) on--bg(#020617)--link(#93c5fd) on--bg(#020617)Fixes for hardcoded colours that failed in dark mode:
.balance-asset#555(3.0:1 ✗)var(--muted).qr-pubkey#666(3.8:1 ✗)var(--muted).sm-history-toggle#666(3.8:1 ✗)var(--muted)#741 — Focus-visible ring on all interactive elements
:root:--focus-ring-color: #2563eb,--focus-ring-width: 2px,--focus-ring-offset: 2px--focus-ring-color: #93c5fd(11.4:1 on#020617✓)input:focus-visible: wasoutline: none— nowoutline: var(--focus-ring-width) solid var(--focus-ring-color)while keepingborder-colorchange.fu-dropzone: removedoutline: nonefrom the base rule; added explicit.fu-dropzone:focus-visiblerule using ring tokens:focus-visiblerule already applied3px solid var(--primary)to all other interactive elements#742 — ARIA live regions for async status updates
AnimatePresencein<div role="status" aria-live="polite">so screen readers announce new balance values after transactions completeMessagecomponent to userole="alert"(assertive) forerror/warningtypes androle="status"(polite) forsuccess/info— prevents disruptive interruptions for non-urgent notifications<div aria-live="polite" aria-atomic="true" className="sr-only">was already present inApp.jsx, announcing "Sending payment…", "Checking balance…", etc.aria-busy: already set on Create, Balance, and Send buttonsTest plan
<main>.balance-asset, QR modal, and message history toggle text are readable