Skip to content

Add CoreModeIceTileOverlay map metadata property#1063

Merged
maddie480 merged 1 commit intoEverestAPI:devfrom
SilverDorian46:ice-tile-overlay-map-metadata
Apr 19, 2026
Merged

Add CoreModeIceTileOverlay map metadata property#1063
maddie480 merged 1 commit intoEverestAPI:devfrom
SilverDorian46:ice-tile-overlay-map-metadata

Conversation

@SilverDorian46
Copy link
Copy Markdown
Contributor

@SilverDorian46 SilverDorian46 commented Jan 9, 2026

this is an effect specific to vanilla Core, which has been unusable in custom maps (without writing a code mod) until now.
if enabled, an ice graphic will be overlaid on the surface of Solid Tiles when the Core Mode is Cold.
may be useful for maps looking to emulate vanilla Core

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Jan 9, 2026
Comment thread Celeste.Mod.mm/Patches/LevelLoader.cs Outdated
@maddie480-bot
Copy link
Copy Markdown
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Apr 19, 2026, 7:42 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Apr 16, 2026
Copy link
Copy Markdown
Member

@microlith57 microlith57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last approving review, for fun

@maddie480-bot
Copy link
Copy Markdown
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Apr 19, 2026, 11:20 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot
Copy link
Copy Markdown
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Apr 19, 2026
@maddie480
Copy link
Copy Markdown
Member

maddie480 commented Apr 19, 2026

I said "update with rebase", thanks GitHub (since the history vanished: I hit "update branch" to run the tests one last time before merging, and that dum dum made a merge commit instead)

@maddie480 maddie480 force-pushed the ice-tile-overlay-map-metadata branch from b1ac854 to 06465b9 Compare April 19, 2026 12:11
@maddie480
Copy link
Copy Markdown
Member

maddie480 commented Apr 19, 2026

@maddie480 maddie480 merged commit 8705690 into EverestAPI:dev Apr 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants