fix(mapping): correct category option listing in global mapping dialog#1051
Open
ifoche wants to merge 1 commit intodevelopmentfrom
Open
fix(mapping): correct category option listing in global mapping dialog#1051ifoche wants to merge 1 commit intodevelopmentfrom
ifoche wants to merge 1 commit intodevelopmentfrom
Conversation
MappingDialog always used modelFactory("categoryOptions") which resolved
to CategoryOptionMappedModel — a model that expands each category option
into N rows (one per parent category) with composite IDs. This caused
three bugs in global mapping: duplicate destination entries, mappings
appearing lost on re-open, and automap results invisible.
Fix by passing the source model from MappingTable to MappingDialog via
config, so the destination picker uses the same model as the source
(GlobalCategoryOptionModel for global mapping, which lists plain IDs
without category expansion). Falls back to modelFactory for nested
mapping contexts.
Also adds .claude/ to .gitignore and includes OpenSpec change artifacts.
Closes: https://app.clickup.com/t/869bvjqn0
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
ifoche
force-pushed
the
fix/category-option-mapping
branch
from
1ce0c6f to
867e314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause:
MappingDialogalways usedmodelFactory("categoryOptions")which resolved toCategoryOptionMappedModel— a model that expands each category option into N composite-ID rows. The fix passes the correct model fromMappingTabletoMappingDialogvia the config, usingGlobalCategoryOptionModel(plain IDs, no expansion) for global mapping while preserving composite IDs for nested mapping.Related Tasks
Test plan
yarn test— all 388 tests pass (47 files)yarn build core-app— builds cleanly🤖 Generated with Claude Code