Serialize faction as string in game launch message#835
Serialize faction as string in game launch message#835
Conversation
|
One integration test is broken, but I don't know why, because it seems totally unrelated to me. |
|
You need to make sure the integer value is still used for faction to update the game_stats entries |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
75a18d1 to
0a667d2
Compare
|
What are we going to do with this, given that we want to reduce the number of open PRs, but v2 is probably a long time away? |
|
Well, since I’m not actively working on the server much anymore we should probably release a less ambitious version of the v2 changes that just includes what we have so far. We can always do a v3 later if more stuff gets done. I have merged some breaking change stuff onto the |
Closes #834