Enable GET for container endpoints#844
Draft
dennisvang wants to merge 10 commits into
Draft
Conversation
Contributor
Author
|
The |
This has optional paging, instead of the required paging implemented for the explicit */page/<container> controller.
in favor of the */<container>/ controller with optional paging
redundant variable assignment instead of returning directly, but this helps with clarity and debugging with todos
dennisvang
force-pushed
the
feature/842-get-container
branch
from
01c1f65 to
99f46ea
Compare
This shows that the two implementations are *not* identical in the way they handle null values...
dennisvang
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables GET requests to container endpoints, such as
catalog/,dataset/,catalog/<id>/dataset/, and so on.Paging is optional, depending on the presence of query parameters
pageandsize.The original
pageendpoints are now deprecated, but we keep them around for backward compatibility."{childPrefix}/""{oUrlPrefix:[^.]+}/{oRecordId:[^.]+}/{childPrefix}/"pagepaths:"page/{childPrefix}""{oUrlPrefix:[^.]+}/{oRecordId:[^.]+}/page/{childPrefix}"replaced
for (...) {if (condition) {return ...}}pattern bystream.filter(condition).findFirst()for clarity (and reusability)todo:
fixes #842