Skip to content

Removed "Created *" fields since these are now standard BC fields. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DevHarmonize wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed "Created *" fields since these are now standard BC fields. #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 2 additions & 33 deletions AppSourcePublishing/appsource-requirements.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,19 +242,7 @@ table 50100 "ABC Customer Rating"
{
Caption = 'Comments';
DataClassification = CustomerContent;
}
field(7; "Created By"; Code[50])
{
Caption = 'Created By';
DataClassification = EndUserIdentifiableInformation;
Editable = false;
}
field(8; "Created Date Time"; DateTime)
{
Caption = 'Created Date Time';
DataClassification = CustomerContent;
Editable = false;
}
}
}

keys
Expand All @@ -278,10 +266,7 @@ table 50100 "ABC Customer Rating"
trigger OnInsert()
begin
if "No." = '' then
NoSeriesMgt.InitSeries(GetNoSeriesCode(), xRec."No. Series", 0D, "No.", "No. Series");

"Created By" := CopyStr(UserId(), 1, MaxStrLen("Created By"));
"Created Date Time" := CurrentDateTime;
NoSeriesMgt.InitSeries(GetNoSeriesCode(), xRec."No. Series", 0D, "No.", "No. Series");

if "Rating Date" = 0D then
"Rating Date" := Today;
Expand Down Expand Up @@ -424,22 +409,6 @@ page 50100 "ABC Customer Rating Card"
MultiLine = true;
}
}
group(Administration)
{
Caption = 'Administration';
field("Created By"; Rec."Created By")
{
ApplicationArea = All;
ToolTip = 'Specifies who created this rating.';
Editable = false;
}
field("Created Date Time"; Rec."Created Date Time")
{
ApplicationArea = All;
ToolTip = 'Specifies when this rating was created.';
Editable = false;
}
}
}
area(FactBoxes)
{
Expand Down
24 changes: 0 additions & 24 deletions SharedGuidelines/Utilities/page-template.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,6 @@ page [ObjectID] "[Prefix] [EntityName] Card"
end;
}
}
group(Details)
{
Caption = 'Details';
field("Created Date"; Rec."Created Date")
{
ApplicationArea = All;
Editable = false;
}
field("Created By"; Rec."Created By")
{
ApplicationArea = All;
Editable = false;
}
// Add additional detail fields as needed
}
group(Statistics)
{
Caption = 'Statistics';
Expand Down Expand Up @@ -250,15 +235,6 @@ page [ObjectID] "[Prefix] [EntityName] List"
ApplicationArea = All;
StyleExpr = StatusStyleExpr;
}
field("Created Date"; Rec."Created Date")
{
ApplicationArea = All;
}
field("Created By"; Rec."Created By")
{
ApplicationArea = All;
Visible = false;
}
field("Related Records Count"; Rec."Related Records Count")
{
ApplicationArea = All;
Expand Down
22 changes: 2 additions & 20 deletions SharedGuidelines/Utilities/table-template.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,6 @@ table [ObjectID] "[Prefix] [EntityName]"
DataClassification = CustomerContent;
NotBlank = true;
}
field(3; "Created Date"; Date)
{
Caption = 'Created Date';
Tooltip = 'Specifies when the [entity] was created.';
DataClassification = CustomerContent;
Editable = false;
}
field(4; "Created By"; Code[50])
{
Caption = 'Created By';
Tooltip = 'Specifies who created the [entity].';
DataClassification = EndUserIdentifiableInformation;
TableRelation = User."User Name";
Editable = false;
}
field(5; Status; Enum "[Prefix] [EntityName] Status")
{
Caption = 'Status';
Expand Down Expand Up @@ -85,7 +70,7 @@ table [ObjectID] "[Prefix] [EntityName]"
{
// Secondary key for sorting and filtering
}
key(Status; Status, "Created Date")
key(Status; Status)
{
// Composite key for status-based queries
}
Expand All @@ -94,17 +79,14 @@ table [ObjectID] "[Prefix] [EntityName]"
fieldgroups
{
fieldgroup(DropDown; "No.", Description, Status) { }
fieldgroup(Brick; "No.", Description, Status, "Created Date") { }
fieldgroup(Brick; "No.", Description, Status") { }
}

trigger OnInsert()
begin
if "No." = '' then
NoSeriesMgt.InitSeries('[NoSeriesCode]', xRec."No. Series", 0D, "No.", "No. Series");

"Created Date" := Today;
"Created By" := CopyStr(UserId(), 1, MaxStrLen("Created By"));

if Status = Status::" " then
Status := Status::Active;
end;
Expand Down