fix(shadows): use cloud-computed delta in sync_shadow#130
Merged
Conversation
Previously sync_shadow re-applied the full `desired` blob on every boot, firing `apply_delta_and_ack` (and any side-effects gated on a Some delta) even when desired matched reported. Use AWS's `delta` field so callers can rely on `None` to skip work when nothing actually changed.
MathiasKoch
approved these changes
Jun 1, 2026
Member
|
@KennethKnudsen97 Is this right? Seems like it is referenced in our firmware, and should have been merged instead? |
Contributor
Author
|
@MathiasKoch I think it autoclosed it. seems like a weird feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync_shadowpreviously re-applied the fulldesiredblob on every boot, firingapply_delta_and_ack(and any caller side-effects gated on aSomedelta) even when desired matched reported. Switch to AWS'sdeltafield so callers can rely onNoneto skip work when nothing actually changed.The original reason for preferring
desired— narrow deltas missing parent variant tags — is now handled by the bare-string variant fallback in #129.