Skip to content

Use music discs c-tag rather than vanilla creeper-drops tag #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Robotgiggle merged 1 commit into from
Jun 14, 2026
Merged

Use music discs c-tag rather than vanilla creeper-drops tag #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Common/src/generated/resources/data/hexcasting/recipe/artifact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"item": "hexcasting:charged_amethyst"
},
"D": {
"tag": "minecraft:creeper_drop_music_discs"
"tag": "c:music_discs"
},
"F": {
"tag": "c:ingots/gold"
Expand Down
6 changes: 3 additions & 3 deletions Common/src/main/java/at/petrak/hexcasting/datagen/recipe/HexplatRecipes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import net.minecraft.advancements.critereon.ItemPredicate;
import net.minecraft.core.HolderLookup;
import net.minecraft.core.registries.BuiltInRegistries;
import net.minecraft.core.registries.Registries;
import net.minecraft.data.PackOutput;
import net.minecraft.data.recipes.*;
import net.minecraft.resources.ResourceLocation;
Expand Down Expand Up @@ -155,9 +156,8 @@ public void buildRecipes(RecipeOutput recipes) {
ShapedRecipeBuilder.shaped(RecipeCategory.TOOLS, HexItems.ARTIFACT)
.define('F', ingredients.goldIngot())
.define('A', HexItems.CHARGED_AMETHYST)
// why in god's name does minecraft have two different places for item tags
// TODO port: check if good for music discs
.define('D', ItemTags.CREEPER_DROP_MUSIC_DISCS)
// 1.21 removed the vanilla music discs tag so we need to use this instead
.define('D', TagKey.create(Registries.ITEM, ResourceLocation.fromNamespaceAndPath("c","music_discs")))
.pattern(" F ")
.pattern("FAF")
.pattern(" D ")
Expand Down
2 changes: 1 addition & 1 deletion Fabric/src/generated/resources/data/hexcasting/recipe/artifact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"item": "hexcasting:charged_amethyst"
},
"D": {
"tag": "minecraft:creeper_drop_music_discs"
"tag": "c:music_discs"
},
"F": [
{
Expand Down
2 changes: 1 addition & 1 deletion Neoforge/src/generated/resources/data/hexcasting/recipe/artifact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"item": "hexcasting:charged_amethyst"
},
"D": {
"tag": "minecraft:creeper_drop_music_discs"
"tag": "c:music_discs"
},
"F": {
"tag": "c:ingots/gold"
Expand Down
Loading