Skip to content

fix(cache): revalidate staged sources before deploy#1096

Merged
zackees merged 1 commit into
mainfrom
fix/1075-stage-cache-invalidation
Jul 16, 2026
Merged

fix(cache): revalidate staged sources before deploy#1096
zackees merged 1 commit into
mainfrom
fix/1075-stage-cache-invalidation

Conversation

@zackees

@zackees zackees commented Jul 16, 2026

Copy link
Copy Markdown
Member

Fixes #1075

The daemon watch-set fingerprint cache no longer reuses a two-second-old source hash by default. This prevents AutoResearch staging from deploying a cached firmware artifact that predates the staged C++ source.

Validation:

  • soldr cargo clippy -p fbuild-daemon --all-targets -- -D warnings
  • soldr cargo test -p fbuild-daemon --lib (197 passed, 1 ignored)
  • Regression test: default cache rejects an immediate post-staging lookup

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: afe874f8-7382-4fbf-9a97-c9745332f755

📥 Commits

Reviewing files that changed from the base of the PR and between 83a5018 and 8018b4e.

📒 Files selected for processing (2)
  • crates/fbuild-daemon/src/context.rs
  • crates/fbuild-daemon/src/watch_set_cache.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/1075-stage-cache-invalidation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 374de40 into main Jul 16, 2026
87 of 93 checks passed
@zackees
zackees deleted the fix/1075-stage-cache-invalidation branch July 16, 2026 13:15
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

fbuild: staged AutoResearch C++ changes do not invalidate RP2040 deploy cache

1 participant