Skip to content

Redesign NUClearNet and rename to nuclearnet #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrentHouliston wants to merge 53 commits into
base: main
Choose a base branch
from

fix: resolve clang-tidy issues in Routing and wire_protocol tests

c1a66d0
Select commit
Loading
Failed to load commit list.
Open

Redesign NUClearNet and rename to nuclearnet #190

fix: resolve clang-tidy issues in Routing and wire_protocol tests
c1a66d0
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 4, 2026 in 1m 26s

Quality Gate passed

Issues
57 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 799 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this specialization with "bool" of "std::vector". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5tOtMWhJ2iGPVI1yeM&open=AZ5tOtMWhJ2iGPVI1yeM&pullRequest=190

Check failure on line 833 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5tEot6oIt0FrcHv56P&open=AZ5tEot6oIt0FrcHv56P&pullRequest=190

Check failure on line 831 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5tEot6oIt0FrcHv56M&open=AZ5tEot6oIt0FrcHv56M&pullRequest=190

Check warning on line 247 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohl". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDs1&open=AZ5oA9JpE8YQNFI7nDs1&pullRequest=190

Check warning on line 122 in src/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JaE8YQNFI7nDsr&open=AZ5oA9JaE8YQNFI7nDsr&pullRequest=190

Check failure on line 444 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ6MbTXC2KogQpv0vJkU&open=AZ6MbTXC2KogQpv0vJkU&pullRequest=190

Check warning on line 118 in src/nuclearnet/Reliability.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this specialization with "bool" of "std::vector". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9KIE8YQNFI7nDtW&open=AZ5oA9KIE8YQNFI7nDtW&pullRequest=190

Check warning on line 77 in src/util/network/sock_t.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohl". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9KaE8YQNFI7nDta&open=AZ5oA9KaE8YQNFI7nDta&pullRequest=190

Check failure on line 430 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture "this" in a non-transient lambda. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5tKRnFG-RPh9mCiuQ_&open=AZ5tKRnFG-RPh9mCiuQ_&pullRequest=190

Check warning on line 37 in src/nuclearnet/Log.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename enumeration value "Off" to match the regular expression: ^[A-Z][A-Z_0-9]*$ 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ6MbTWS2KogQpv0vJkH&open=AZ6MbTWS2KogQpv0vJkH&pullRequest=190

Check failure on line 227 in src/nuclearnet/NUClearNet.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ6MbTXm2KogQpv0vJkd&open=AZ6MbTXm2KogQpv0vJkd&pullRequest=190

Check warning on line 713 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5tKRnFG-RPh9mCiuRG&open=AZ5tKRnFG-RPh9mCiuRG&pullRequest=190

Check warning on line 326 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"catch" a specific exception type. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ6QAd_d5nSEz7HZd8iq&open=AZ6QAd_d5nSEz7HZd8iq&pullRequest=190

Check warning on line 98 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "fragmentation". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ6QAd_d5nSEz7HZd8ip&open=AZ6QAd_d5nSEz7HZd8ip&pullRequest=190

Check warning on line 78 in src/util/network/sock_t.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohl". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9KaE8YQNFI7nDtc&open=AZ5oA9KaE8YQNFI7nDtc&pullRequest=190

Check warning on line 70 in src/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JaE8YQNFI7nDsq&open=AZ5oA9JaE8YQNFI7nDsq&pullRequest=190

Check warning on line 326 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ6QAd_d5nSEz7HZd8ir&open=AZ6QAd_d5nSEz7HZd8ir&pullRequest=190

Check warning on line 45 in src/nuclearnet/wire_protocol.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "enum" with "enum class". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JCE8YQNFI7nDsn&open=AZ5oA9JCE8YQNFI7nDsn&pullRequest=190

Check warning on line 195 in src/nuclearnet/wire_protocol.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5tEos4oIt0FrcHv56K&open=AZ5tEos4oIt0FrcHv56K&pullRequest=190

Check failure on line 58 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ6MbTXC2KogQpv0vJkV&open=AZ6MbTXC2KogQpv0vJkV&pullRequest=190

Check warning on line 99 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "reliability". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDsx&open=AZ5oA9JpE8YQNFI7nDsx&pullRequest=190

Check warning on line 39 in src/nuclearnet/Log.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename enumeration value "Warn" to match the regular expression: ^[A-Z][A-Z_0-9]*$ 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ6MbTWS2KogQpv0vJkJ&open=AZ6MbTWS2KogQpv0vJkJ&pullRequest=190

Check warning on line 78 in src/util/network/sock_t.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohs". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9KaE8YQNFI7nDtd&open=AZ5oA9KaE8YQNFI7nDtd&pullRequest=190

Check failure on line 382 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ6MbTXC2KogQpv0vJkQ&open=AZ6MbTXC2KogQpv0vJkQ&pullRequest=190

Check warning on line 95 in src/util/network/sock_t.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohs". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9KaE8YQNFI7nDtg&open=AZ5oA9KaE8YQNFI7nDtg&pullRequest=190
View more details on SonarQubeCloud