Skip to content

Fix clean runner release restore #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FaulMit merged 1 commit into from
Jul 22, 2026
Merged

Fix clean runner release restore #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tools/BuildRelease.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ foreach ($path in @($stagingRoot, $portableArchive, $setupPath, $checksumPath))
New-Item -ItemType Directory -Force -Path $publishDirectory | Out-Null

Write-Host "Publishing Captail $Version..."
dotnet restore $project --locked-mode --artifacts-path $dotnetArtifacts
dotnet restore $project `
--locked-mode `
--runtime win-x64 `

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the self-contained runtime packs

On a clean .NET 9 runner with no runtime packs cached, this restore is still framework-dependent: the .NET 8+ SDK behavior says a RID no longer implies SelfContained, and PublishSingleFile implies it only during dotnet publish, not dotnet restore. The publish immediately below uses --self-contained true --no-restore, so it can still request the Microsoft.NETCore.App/WindowsDesktop runtime packs that this restore did not download and hit NETSDK1112; pass -p:SelfContained=true here too, or set SelfContained in the project.

Useful? React with 👍 / 👎.

--artifacts-path $dotnetArtifacts
if ($LASTEXITCODE -ne 0) {
throw "dotnet restore failed with exit code $LASTEXITCODE."
}
Expand Down
Loading