ci: install JDK 21 so firebase-tools emulators can run#153
Merged
Conversation
The test job runs the Firebase emulators via `npx firebase-tools@latest`, which now requires a JDK at version 21 or above. The workflow had no Java setup step, so the runner's default JDK was used and every emulator run failed at startup with "firebase-tools no longer supports Java version before 21", leaving the whole test matrix red regardless of the firebase or rxjs version under test. Add an actions/setup-java step (Temurin 21) to the test job. Only that job runs the emulators; build and lint do not. The action is pinned to the v5.6.0 commit SHA rather than a floating tag, per GitHub's security hardening guidance for third-party actions.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
tyler-reitz
approved these changes
Jul 20, 2026
tyler-reitz
left a comment
tyler-reitz
left a comment
There was a problem hiding this comment.
Verified the pinned SHA (03ad4de0992f5dab5e18fcb136590ce7c4a0ac95) matches actions/setup-java v5.6.0. Correctly scoped to the test job only. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testjob (the workflow job that runs the emulator matrix) runs the Firebase emulators vianpx firebase-tools@latest, which now requires a JDK at version 21 or above. The workflow has no Java setup step, so the runner's default JDK is used and every emulator run fails at startup with:This has left the whole test matrix red regardless of the firebase or rxjs version under test.
This adds an
actions/setup-javastep (Temurin 21, pinned to the v5.6.0 commit SHA) to thetestjob so the emulators start. Only thetestjob needs it; thebuildandlintjobs do not run the emulators.The action is pinned to a commit SHA rather than a floating tag because a SHA is the only immutable reference, following GitHub's security-hardening guidance for third-party actions.