Skip to content

fix: config set support object value #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linjinze999 wants to merge 2 commits into
base: main
Choose a base branch
from
+62 −30
Open

fix: config set support object value #1123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11ea028
fix: config set support object value
linjinze999 May 25, 2026
58ff806
Merge branch 'main' into feat/config_set_object
linjinze999 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 62 additions & 30 deletions src/commands/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,42 +351,74 @@ export function registerConfigCommand(program: Command): void {
.command('set <key> <value>')
.description('Set a value (auto-coerce types)')
.option('--string', 'Force value to be stored as string')
.option('--json', 'Parse value as JSON (use for arrays/objects)')
.option('--allow-unknown', 'Allow setting unknown keys')
.action((key: string, value: string, options: { string?: boolean; allowUnknown?: boolean }) => {
const allowUnknown = Boolean(options.allowUnknown);
const keyValidation = validateConfigKeyPath(key);
if (!keyValidation.valid && !allowUnknown) {
const reason = keyValidation.reason ? ` ${keyValidation.reason}.` : '';
console.error(`Error: Invalid configuration key "${key}".${reason}`);
console.error('Use "openspec config list" to see available keys.');
console.error('Pass --allow-unknown to bypass this check.');
process.exitCode = 1;
return;
}
.action(
(
key: string,
value: string,
options: { string?: boolean; json?: boolean; allowUnknown?: boolean }
) => {
const allowUnknown = Boolean(options.allowUnknown);
const keyValidation = validateConfigKeyPath(key);
if (!keyValidation.valid && !allowUnknown) {
const reason = keyValidation.reason ? ` ${keyValidation.reason}.` : '';
console.error(`Error: Invalid configuration key "${key}".${reason}`);
console.error('Use "openspec config list" to see available keys.');
console.error('Pass --allow-unknown to bypass this check.');
process.exitCode = 1;
return;
}

const config = getGlobalConfig() as Record<string, unknown>;
const coercedValue = coerceValue(value, options.string || false);
if (options.string && options.json) {
console.error('Error: --string and --json cannot be combined.');
process.exitCode = 1;
return;
}

// Create a copy to validate before saving
const newConfig = JSON.parse(JSON.stringify(config));
setNestedValue(newConfig, key, coercedValue);
let parsedValue: unknown;
if (options.json) {
try {
parsedValue = JSON.parse(value);
} catch (error) {
const message = error instanceof Error ? error.message : String(error);
console.error(`Error: --json was provided but value is not valid JSON: ${message}`);
process.exitCode = 1;
return;
}
} else {
parsedValue = coerceValue(value, options.string || false);
}

// Validate the new config
const validation = validateConfig(newConfig);
if (!validation.success) {
console.error(`Error: Invalid configuration - ${validation.error}`);
process.exitCode = 1;
return;
}
const config = getGlobalConfig() as Record<string, unknown>;

// Apply changes and save
setNestedValue(config, key, coercedValue);
saveGlobalConfig(config as GlobalConfig);
// Create a copy to validate before saving
const newConfig = JSON.parse(JSON.stringify(config));
setNestedValue(newConfig, key, parsedValue);

const displayValue =
typeof coercedValue === 'string' ? `"${coercedValue}"` : String(coercedValue);
console.log(`Set ${key} = ${displayValue}`);
});
// Validate the new config
const validation = validateConfig(newConfig);
if (!validation.success) {
console.error(`Error: Invalid configuration - ${validation.error}`);
process.exitCode = 1;
return;
}

// Apply changes and save
setNestedValue(config, key, parsedValue);
saveGlobalConfig(config as GlobalConfig);

let displayValue: string;
if (typeof parsedValue === 'string') {
displayValue = `"${parsedValue}"`;
} else if (typeof parsedValue === 'object' && parsedValue !== null) {
displayValue = JSON.stringify(parsedValue);
} else {
displayValue = String(parsedValue);
}
console.log(`Set ${key} = ${displayValue}`);
}
);

// config unset
configCmd
Expand Down