Feat/copy assets by joshuaunity · Pull Request #2017 · FlexMeasures/flexmeasures

joshuaunity · 2026-03-11T11:45:42Z

Description

This PR introduces an API allowing users to copy assets from one account to another, using the original account's assets as templates. The feature is currently in progress and being developed incrementally.

##TODO

Successfully Copy Asset to target asset
Write a test to confirm the above feature
Write a test to confirm that asset parents and children are accurate
Successfully copy assets and asset sensors and children to the target asset
Write a test to confirm the above feature
Successfully copy asset flexconfig... (I don't know how feasible this would be yet, maybe 80% ?)
Write a test to confirm the above feature

Look & Feel

None

How to test

Further Improvements

Related Items

This PR closes #1966

Sign-off

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…/copy-assets

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity · 2026-03-11T11:45:55Z

CC @nhoening

read-the-docs-community · 2026-03-11T11:49:40Z

Documentation build overview

📚 flexmeasures | 🛠️ Build #32235629 | 📁 Comparing 47a95bd against latest (8934f22)

🔍 Preview build

Show files changed (7 files in total): 📝 7 modified | ➕ 0 added | ➖ 0 deleted

File	Status
changelog.html	📝 modified
genindex.html	📝 modified
http-routingtable.html	📝 modified
_autosummary/flexmeasures.api.common.utils.api_utils.html	📝 modified
_autosummary/flexmeasures.api.v3_0.assets.html	📝 modified
_autosummary/flexmeasures.data.services.data_sources.html	📝 modified
api/v3_0.html	📝 modified

Flix6x · 2026-03-11T13:30:26Z

Thank you for requesting a review. It looks like the scope of this PR may be mistaken? You are creating an endpoint to copy all assets under a given account*, rather than an endpoint to copy a given asset, including all assets under it.

nhoening · 2026-03-11T13:35:57Z

We can also discuss the test strategy. Joshua chose to implement a part of the solution, then tests for that, then the next part, test for that etc.

I believe we suggested initially to have one test case that tests a complete successful copy, then work on making it pass.

The test can assert the first part first (e.g. assets and subassets are copied), and others later(sensors, flex-config are copied), so you can still follow along how far you are in kaking the test pass, layer by layer.
This way would be more helpful in understanding together if the scope is agreed between all of us. The test is easier to write (I suggest using AI to help) and to read than the actual implementation.

Flix6x · 2026-03-11T13:31:50Z

flexmeasures/ui/static/openapi-specs.json

-          "20 \u00b0C",
-          "3 * 230V * 16A"
-        ]
+        "description": "Quantity string describing a fixed quantity."


This is a mistake.

flexmeasures/ui/static/openapi-specs.json

flexmeasures/api/v3_0/assets.py

Signed-off-by: Joshua Edward <oghenerobojosh01@gmail.com>

Flix6x

Thanks @joshuaunity this is now heading in the right direction. See my comments for the next challenge: a deep copy. Just let me know if any decisions come up.

flexmeasures/api/v3_0/assets.py

flexmeasures/api/v3_0/tests/test_assets_api.py

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

flexmeasures/api/v3_0/assets.py

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Flix6x

A few comments on the schema. I'll move to testing now.

flexmeasures/ui/static/openapi-specs.json

flexmeasures/api/v3_0/assets.py

Flix6x

I was hoping to use Swagger for testing, but I don't see the new endpoint listed on http://localhost:5000/api/v3_0/docs/. I'm delaying testing until I can use that. If you need me to test without it, please provide instructions.

flexmeasures/ui/static/openapi-specs.json

…s and query parameters Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…ated Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

flexmeasures/api/v3_0/assets.py

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com> Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

Flix6x · 2026-04-02T07:45:15Z

@joshuaunity Please fix the failing pipeline and update the PR description (2 todos still marked unresolved).

Flix6x

I tested on an asset with sensors_to_show='[[309, 308], [305], [14, 14]]', where:

309 is a sensor on original asset
sensors 308 and 305 are sensors on a child asset of the original asset
14 is a sensor on a public asset

I was expecting the 30x sensor IDs to be replaced by new IDs, but they were copied verbatim.

flexmeasures/api/common/utils/api_utils.py

joshuaunity · 2026-04-07T09:44:01Z

I tested on an asset with sensors_to_show='[[309, 308], [305], [14, 14]]', where:

309 is a sensor on original asset

sensors 308 and 305 are sensors on a child asset of the original asset

14 is a sensor on a public asset

I was expecting the 30x sensor IDs to be replaced by new IDs, but they were copied verbatim.

Working on this

… graph Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity · 2026-04-07T16:49:32Z

I tested on an asset with sensors_to_show='[[309, 308], [305], [14, 14]]', where:

309 is a sensor on original asset

sensors 308 and 305 are sensors on a child asset of the original asset

14 is a sensor on a public asset

I was expecting the 30x sensor IDs to be replaced by new IDs, but they were copied verbatim.

Working on this

@Flix6x you can test this out again.

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Flix6x · 2026-04-10T14:48:21Z

@copilot please fix the failing pipeline on this PR branch. Do not make a new PR. Then, review this PR.

…d import CI failure Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/6d233bee-2f46-40a4-b52b-76ac30ff565d Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

Copilot · 2026-04-10T14:56:38Z

@copilot please fix the failing pipeline on this PR branch. Do not make a new PR. Then, review this PR.

Fixed in commit 3b8dd82. The CI failure was caused by unused Annotation and get_or_create_annotation imports (F401 flake8 errors). These were unused because the post_annotation function that uses them was accidentally dropped during the merge at commit 4e84d1f. I've restored the function, and all pre-commit hooks (flake8, black, mypy, OpenAPI spec generation) now pass.

Flix6x

While testing, a lot works very well now. A few things left:

Regression: on opening the Edit Graphs modal, I get toast notifications showing "Unknown graph format: 124". It doesn't happen on main. Can you reproduce it?
I also had copilot fix the failing pipeline, but I still see the POST annotations endpoint being deleted from openapi-specs.json in this PR. I don't know why, please investigate.
When copying an asset twice, the second copy gets the same name as the first copy. I think subsequent copies should get a number, so:
- Home
- Home (Copy)
- Home (Copy 2)
- Home (Copy 3)
- etc.
Please update the PR description.
Missing changelog entry.

Flix6x · 2026-04-10T15:05:59Z

flexmeasures/ui/static/openapi-specs.json

        ]
      }
    },
-    "/api/v3_0/assets/{id}/annotations": {


This should not disappear. See also #2017 (comment)

I ran the make command, and this didnt get deleted

joshuaunity · 2026-04-13T03:53:27Z

Regression: on opening the Edit Graphs modal, I get toast notifications showing "Unknown graph format: 124". It doesn't happen on main. Can you reproduce it?

What does your sensors_to_show look like on your DB

…ndpoint for asset annotations Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

Flix6x · 2026-04-13T06:38:24Z

(I don't know how feasible this would be yet, maybe 80% ?)

Are we now at 100% or are there still cases where you expect copying flex-config to fail?

Flix6x · 2026-04-13T08:10:45Z

Regression: on opening the Edit Graphs modal, I get toast notifications showing "Unknown graph format: 124". It doesn't happen on main. Can you reproduce it?

What does your sensors_to_show look like on your DB

> select sensors_to_show from generic_asset where id=46;
   sensors_to_show    
----------------------
 [121, 122, 123, 124]

joshuaunity · 2026-04-13T09:04:03Z

Regression: on opening the Edit Graphs modal, I get toast notifications showing "Unknown graph format: 124". It doesn't happen on main. Can you reproduce it?

What does your sensors_to_show look like on your DB
> select sensors_to_show from generic_asset where id=46;
   sensors_to_show    
----------------------
 [121, 122, 123, 124]

thanks

Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

joshuaunity · 2026-04-13T10:56:56Z

Are we now at 100% or are there still cases where you expect copying flex-config to fail?

we are at 100% i would say, as of my tests on Friday, flex config was copied over nicely.

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity · 2026-04-13T12:51:07Z

Regression: on opening the Edit Graphs modal, I get toast notifications showing "Unknown graph format: 124".

This is now fixed.

@Flix6x

joshuaunity added 6 commits March 5, 2026 16:25

chore: initialize repo

a886a66

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

chore: work in progress

5fc6e42

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

tests: added test to test for cpy asset feature

09e879f

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Merge branch 'main' of github.com:FlexMeasures/flexmeasures into feat…

f588302

…/copy-assets

chore: removed unused file

3f97255

refactor: relocate util function

d609e37

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity requested a review from Flix6x March 11, 2026 11:45

joshuaunity self-assigned this Mar 11, 2026

joshuaunity added the enhancement New feature or request label Mar 11, 2026

Flix6x requested changes Mar 11, 2026

View reviewed changes

refacto: Refactored util for copying asset

abd590b

Signed-off-by: Joshua Edward <oghenerobojosh01@gmail.com>

joshuaunity requested a review from Flix6x March 13, 2026 12:03

joshuaunity and others added 2 commits March 13, 2026 17:23

tests: and new test case

fb39eac

Signed-off-by: Joshua Edward <oghenerobojosh01@gmail.com>

Merge branch 'main' into feat/copy-assets

71810d0

Flix6x requested changes Mar 16, 2026

View reviewed changes

flexmeasures/api/v3_0/assets.py Outdated Show resolved Hide resolved

flexmeasures/api/v3_0/tests/test_assets_api.py Outdated Show resolved Hide resolved

flexmeasures/api/v3_0/tests/test_assets_api.py Outdated Show resolved Hide resolved

joshuaunity added 2 commits March 16, 2026 15:34

chore: move logic into @post_load

5371a4e

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

feat: implement deep copy of asset subtree including direct sensors

e84899e

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Flix6x reviewed Mar 17, 2026

View reviewed changes

flexmeasures/api/v3_0/assets.py Show resolved Hide resolved

feat: add permission requirement for copying assets

510fa71

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity requested a review from Flix6x March 18, 2026 09:51

Flix6x requested changes Mar 18, 2026

View reviewed changes

flexmeasures/ui/static/openapi-specs.json Outdated Show resolved Hide resolved

flexmeasures/api/v3_0/assets.py Show resolved Hide resolved

Flix6x requested changes Mar 18, 2026

View reviewed changes

flexmeasures/ui/static/openapi-specs.json Outdated Show resolved Hide resolved

joshuaunity added 2 commits March 18, 2026 13:02

feat: enhance asset copy endpoint with detailed OpenAPI specification…

bb6e959

…s and query parameters Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

feat: add test for asset copy API to ensure direct sensors are duplic…

9952e5b

…ated Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Flix6x reviewed Mar 18, 2026

View reviewed changes

flexmeasures/api/v3_0/assets.py Outdated Show resolved Hide resolved

flexmeasures/api/v3_0/assets.py Outdated Show resolved Hide resolved

flexmeasures/api/v3_0/assets.py Outdated Show resolved Hide resolved

Update flexmeasures/api/v3_0/assets.py

d9eacf7

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com> Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

joshuaunity requested a review from nhoening March 30, 2026 13:18

Merge branch 'main' into feat/copy-assets

4e84d1f

Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

Flix6x added the Still Needs Changelog Entry label Apr 2, 2026

Flix6x requested changes Apr 2, 2026

View reviewed changes

flexmeasures/api/common/utils/api_utils.py Show resolved Hide resolved

flexmeasures/api/common/utils/api_utils.py Outdated Show resolved Hide resolved

joshuaunity added 2 commits April 7, 2026 12:54

fix: improve sensor reference handling and format validation in asset…

67446b6

… graph Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

feat: add audit log entry for asset copying in copy_asset function

b195085

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

feat: add option to include copy suffix when duplicating assets

04c25ee

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity requested a review from Flix6x April 9, 2026 19:07

Copilot started work on behalf of Flix6x April 10, 2026 14:48 View session

fix: restore post_annotation function lost during merge, fixing unuse…

3b8dd82

…d import CI failure Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/6d233bee-2f46-40a4-b52b-76ac30ff565d Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

Copilot finished work on behalf of Flix6x April 10, 2026 14:57

Flix6x requested changes Apr 10, 2026

View reviewed changes

joshuaunity and others added 3 commits April 13, 2026 05:25

feat: implement incremental naming for asset copies and add new API e…

ca4c390

…ndpoint for asset annotations Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

chore: added changelog entry

8769a5d

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Merge branch 'main' into feat/copy-assets

a1b807f

Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

Flix6x added API and removed Still Needs Changelog Entry labels Apr 13, 2026

Merge branch 'main' into feat/copy-assets

a2b86ab

Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

feat: add support for numeric graph format in asset graph template

47a95bd

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Conversation

joshuaunity commented Mar 11, 2026 • edited by Flix6x Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Look & Feel

How to test

Further Improvements

Related Items

Sign-off

Uh oh!

joshuaunity commented Mar 11, 2026

Uh oh!

read-the-docs-community bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation build overview

Uh oh!

Flix6x commented Mar 11, 2026

Uh oh!

nhoening commented Mar 11, 2026

Uh oh!

Flix6x Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Flix6x Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Flix6x commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joshuaunity commented Apr 7, 2026

Uh oh!

joshuaunity commented Apr 7, 2026

Uh oh!

Flix6x commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026 • edited by Flix6x Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flix6x left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Flix6x Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

joshuaunity Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

joshuaunity commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flix6x commented Apr 13, 2026

Uh oh!

Flix6x commented Apr 13, 2026

joshuaunity commented Mar 11, 2026 •

edited by Flix6x

Loading

read-the-docs-community bot commented Mar 11, 2026 •

edited

Loading

Flix6x commented Apr 2, 2026 •

edited

Loading

Copilot AI commented Apr 10, 2026 •

edited by Flix6x

Loading

Flix6x left a comment •

edited

Loading

joshuaunity commented Apr 13, 2026 •

edited

Loading

joshuaunity commented Apr 13, 2026 •

edited

Loading