Skip to content

Update paymentMethod info#41

Merged
CiottoliDev merged 1 commit into
FlowPay:v2sfrom
CiottoliDev:v2s
Feb 18, 2026
Merged

Update paymentMethod info#41
CiottoliDev merged 1 commit into
FlowPay:v2sfrom
CiottoliDev:v2s

Conversation

@CiottoliDev
Copy link
Copy Markdown
Member

No description provided.

@CiottoliDev CiottoliDev merged commit 95bf386 into FlowPay:v2s Feb 18, 2026
1 check passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9a27cc11f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread openapi.json
Comment on lines +3228 to 3230
{
"$ref": "#/components/schemas/OpenbankingTechnology"
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow technology field in composed paymentMethod branches

The new Technology.oneOf branches compose the discriminator object with payload schemas via allOf, but the referenced payload schemas (OpenbankingTechnology, CardPaymentMethodPayload, BPayTechnology) all have additionalProperties: false and do not declare technology. In JSON Schema composition this means a normal payload like {"technology":"openbanking","bank":"..."} fails validation because the second schema rejects technology, so the openbanking/card/BANCOMAT branches become effectively unreachable and only the saved-method branch can validate.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant