Skip to content

docs(customer): 📝 align POST /customers schema#47

Merged
RaesakAce merged 1 commit into
FlowPay:v2sfrom
alsd4git:v2s
Apr 15, 2026
Merged

docs(customer): 📝 align POST /customers schema#47
RaesakAce merged 1 commit into
FlowPay:v2sfrom
alsd4git:v2s

Conversation

@alsd4git
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1973a0b81c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread openapi.json
Comment on lines +3040 to +3042
"required": [
"tin",
"phoneNumber"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Make tin optional in CustomerCreate schema

The schema marks tin as required, but the tin field description explicitly says it is optional when the customer entity already exists. This inconsistency causes schema-driven SDKs and request validators to reject a request shape that the documentation says should be valid, blocking the existing-entity creation flow unless users bypass validation.

Useful? React with 👍 / 👎.

Comment thread openapi.json
"srtp"
]
},
"example": "[srtp]",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fix services example to match array type

services is defined as an array of enum strings, but the example is a single string ("[srtp]") rather than JSON array syntax. This produces an invalid example payload for this schema and can mislead integrators (or fail example validation) into sending the wrong request shape.

Useful? React with 👍 / 👎.

@RaesakAce RaesakAce merged commit 5c54c77 into FlowPay:v2s Apr 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants