Skip to content

feat(ui): add document store rename/delete actions for cards and table#6041

Open
sahil2448 wants to merge 8 commits intoFlowiseAI:mainfrom
sahil2448:feat/docstore-rename-delete-actions
Open

feat(ui): add document store rename/delete actions for cards and table#6041
sahil2448 wants to merge 8 commits intoFlowiseAI:mainfrom
sahil2448:feat/docstore-rename-delete-actions

Conversation

@sahil2448
Copy link
Copy Markdown

@sahil2448 sahil2448 commented Mar 23, 2026

PR Title

feat(ui): add document store rename/delete actions in card + table views

Fixes : #6040

Summary

This PR adds a simple 3-dot action menu for each Document Store item in both Card and Table views.

Users can now:

  • Rename a document store (name + description)
  • Delete a document store (with confirmation)

The goal is to make document store management faster and more user-friendly without opening each store page.

Why this change?

Previously, quick item-level actions were missing in the Document Store list UI.
Also, table actions had delayed visual updates (loading/skeleton refresh), which felt slow even when API actions succeeded.

This update improves:

  • Discoverability of actions
  • Instant feedback in UI after rename/delete
  • Responsive layout behavior for action icon placement

What changed

1) Card View Actions

  • Added 3-dot vertical menu button (@tabler/icons-react) on each card
  • Menu contains:
    • Rename
    • Delete
  • Prevented UI overlap between menu button and card status/tag area by reserving safe header space

2) Table View Actions

  • Added action support in table rows via 3-dot menu
  • Added Rename + Delete options consistent with card behavior

3) Rename Flow

  • Rename opens dialog in edit mode
  • User can update:
    • Name
    • Description
  • Updated document store list state locally after success (no unnecessary full reload for edit path)

4) Delete Flow

  • Added confirmation dialog before deletion
  • On success:
    • Store is removed immediately from visible list
    • Related image state is cleaned
    • Pagination total is updated
    • Success toast is shown
  • On error:
    • Error toast is shown with backend message when available

Scope Control

  • Changes are limited to Document Store card/table management actions only
  • No unrelated UI components or features were modified

Files Updated

  • packages/ui/src/views/docstore/index.jsx
  • packages/ui/src/ui-component/table/DocumentStoreTable.jsx
  • packages/ui/src/views/docstore/AddDocStoreDialog.jsx
  • packages/ui/src/ui-component/cards/DocumentStoreCard.jsx

Testing Notes

Manual checks performed:

  • Card view: rename/delete menu opens and actions work
  • Table view: rename/delete actions work and list updates immediately
  • Confirmation and toast behaviors are correct
  • Card action icon no longer overlaps status/tag area
  • Responsive behavior checked for action placement

Screenshots / Video

Screenshot 2026-03-24 003044 Screenshot 2026-03-24 003033
Screen.Recording.2026-03-24.011958.mp4

Checklist

  • Used existing icon library (@tabler/icons-react)
  • Added real rename/delete functionality
  • Kept changes scoped to Document Store card/table actions
  • Improved responsive action placement
  • Avoided breaking unrelated features

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user interface for managing document stores by integrating rename and delete actions directly into the card and table views. The changes aim to streamline the workflow, making document store management faster and more intuitive by providing immediate feedback and improving the discoverability of these common operations, ultimately reducing the need to navigate to separate detail pages for simple edits or removals.

Highlights

  • Document Store Actions: Introduced a 3-dot action menu for each Document Store item in both Card and Table views, allowing users to perform quick actions without navigating to individual store pages.
  • Rename Functionality: Users can now rename a document store (name and description) directly from the action menu, with updates reflected locally in the UI for instant feedback.
  • Delete Functionality: Users can delete a document store with a confirmation dialog. Upon successful deletion, the store is immediately removed from the list, associated images are cleaned, and pagination totals are updated.
  • Improved UI Responsiveness: Addressed delayed visual updates in table actions and prevented UI overlap between the action menu button and card status/tag areas, enhancing user experience with instant feedback and better layout.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds rename and delete functionality for document stores from the card and table views, which is a great enhancement for user experience. The implementation is solid, using local state updates to provide instant feedback and leveraging hooks for confirmation dialogs and permissions. I have one suggestion to simplify the state update logic for renaming, which would improve code readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add Rename/Delete Actions (3-Dot Menu) for Document Stores in Card and Table Views

1 participant