fix(ui): validate optional tool icon URL and add fallback icon in too…#6370
Closed
sahil2448 wants to merge 3 commits into
Closed
fix(ui): validate optional tool icon URL and add fallback icon in too…#6370sahil2448 wants to merge 3 commits into
sahil2448 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new icon handling mechanism for tools, including fallback icon support and URL validation for tool icons. It adds IconAvatar and ToolIconAvatar components to handle image loading errors and provides a validation utility in ToolDialog to ensure icon sources are valid HTTP/HTTPS URLs. Feedback includes a suggestion to prevent infinite loops in the onError handler if a fallback icon fails, a recommendation to deduplicate the avatar component logic into a shared component, and an optimization for the submit button's disabled state by using existing error state instead of re-validating on every render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BugFix : Added Validation check for TOOL ICON SOURCE Field in Tools Dialogue, and add a default icon image if user has not provided
Related issue
Closes #6369
Summary
This PR improves the Tools icon UX by making Tool Icon Source optional while validating it when provided.
What’s fixed
Problem
Previously:
Changes
Frontend
ToolDialog.jsx
ToolsListTable.jsx
ItemCard.jsx
tools/index.jsx
Behavior after this PR
Screen.Recording.2026-05-12.002742.mp4
Testing done
Scope / Notes