Skip to content

Fix Flowise 849 SSO And Role#6634

Open
yau-wd wants to merge 1 commit into
mainfrom
fix/flowise-849-sso-and-role
Open

Fix Flowise 849 SSO And Role#6634
yau-wd wants to merge 1 commit into
mainfrom
fix/flowise-849-sso-and-role

Conversation

@yau-wd

@yau-wd yau-wd commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

FLOWISE-849

@yau-wd yau-wd self-assigned this Jul 17, 2026
@yau-wd yau-wd added the bug Something isn't working label Jul 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces enterprise platform and organization validation checks to the login method configuration, and adds an organization mismatch check when updating roles. A critical issue was identified in the role update logic where a partial update with an undefined organization ID would incorrectly trigger a role-not-found error; a code suggestion has been provided to resolve this.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/server/src/enterprise/services/role.service.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants