fix: honor telemetry opt-out#6635
Open
AkhilTrivediX wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to disable telemetry by setting the DISABLE_FLOWISE_TELEMETRY environment variable to 'true'. It updates the Telemetry class constructor to check this variable and adds corresponding unit tests to verify the behavior, including proper cleanup of environment variables in the test suite. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DISABLE_FLOWISE_TELEMETRY=truebefore creating the PostHog clientRoot cause
DISABLE_FLOWISE_TELEMETRYwas passed through the CLI and deployment configuration but was never read by the telemetry initializer. As a result, setting the documented opt-out did not prevent PostHog telemetry from being enabled whenPOSTHOG_PUBLIC_API_KEYwas present.Validation
pnpm --dir packages/server exec jest src/utils/telemetry.test.ts --runInBandpnpm exec prettier --check packages/server/src/utils/telemetry.ts packages/server/src/utils/telemetry.test.tsFixes #6618