Skip to content

fix: respect DISABLE_FLOWISE_TELEMETRY env var for telemetry opt-out #6637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzhzhangzhihao wants to merge 2 commits into
base: main
Choose a base branch
from
+38 −2
Open

fix: respect DISABLE_FLOWISE_TELEMETRY env var for telemetry opt-out #6637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c83a4
fix: unEscapeSpecialChars now handles all RediSearch special characters
Jul 17, 2026
88f0a4f
fix: respect DISABLE_FLOWISE_TELEMETRY env var for telemetry opt-out
Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion packages/components/nodes/vectorstores/Redis/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,38 @@ export const escapeAllStrings = (obj: object) => {
}

export const unEscapeSpecialChars = (str: string) => {
return str.replaceAll('\\-', '-')
// RediSearch special characters that need to be unescaped
// https://redis.io/docs/latest/develop/interact/search-and-query/advanced/concepts/special-characters/
const specialChars = [
'\\-', '-',
'\\,', ',',
'\\<', '<',
'\\>', '>',
'\\{', '{',
'\\}', '}',
'\\[', '[',
'\\]', ']',
'\"', '"',
"\'", "'",
Comment on lines +41 to +42

@gemini-code-assist gemini-code-assist Bot Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In JavaScript/TypeScript, the backslash in '\"' and "\'" acts as an escape character for the quote character itself within the string literal. Since double quotes do not need to be escaped inside single quotes (and vice versa), '\"' evaluates to " (length 1) and "\'" evaluates to ' (length 1).

As a result, the loop executes str.replaceAll('"', '"') and str.replaceAll("'", "'"), which does nothing and fails to unescape the actual backslash-escaped quotes (e.g., \" and \\') returned by Redis. This will cause JSON.parse to fail when parsing metadata containing quotes.

To fix this, escape the backslash itself so that the search strings are of length 2 (representing a literal backslash followed by a quote).

Suggested change
'\"', '"',
"\'", "'",
'\\"', '"',
"\\'", "'",

'\\:', ':',
'\\;', ';',
'\\!', '!',
'\\@', '@',
'\\#', '#',
'\\$', '$',
'\\%', '%',
'\\^', '^',
'\\&', '&',
'\\*', '*',
'\\(', '(',
'\\)', ')',
'\\+', '+',
'\\=', '=',
'\\~', '~',
]

for (let i = 0; i < specialChars.length; i += 2) {
str = str.replaceAll(specialChars[i], specialChars[i + 1])
}
return str
}
5 changes: 4 additions & 1 deletion packages/server/src/utils/telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ export class Telemetry {
postHog?: PostHog

constructor() {
if (process.env.POSTHOG_PUBLIC_API_KEY) {
// Respect DISABLE_FLOWISE_TELEMETRY env var / CLI flag for opt-out
if (process.env.DISABLE_FLOWISE_TELEMETRY === 'true' || process.env.DISABLE_FLOWISE_TELEMETRY === '1') {
this.postHog = undefined
} else if (process.env.POSTHOG_PUBLIC_API_KEY) {
this.postHog = new PostHog(process.env.POSTHOG_PUBLIC_API_KEY)
} else {
this.postHog = undefined
Expand Down