[OPE-197] chore(security): bump Go to 1.25.11 + golangci-lint v2#130
Merged
Conversation
Clears the 7 Go standard-library govulncheck findings (net/textproto, crypto/x509, html/template, net) that can only be fixed by building with a patched toolchain; Go 1.24 is EOL so the fixes exist only in 1.25.x. - go.mod: toolchain go1.24.5 -> go1.25.11 - ci.yml / security.yml: go-version -> 1.25 - Dockerfile: golang:alpine -> golang:1.25-alpine (both stages) The toolchain bump requires golangci-lint v2 (the pinned v1.64.8 was built with go1.24 and refuses go1.25 targets): - golangci-lint-action @v6 -> @v7; migrate .golangci.yml to v2 format - v2 folds stylecheck/quickfix into staticcheck, surfacing 14 findings, all fixed: ST1005 capitalized error strings (opsgenie, teams, import) and QF1012/QF1003 (fmt.Fprintf over WriteString(Sprintf); tagged switch) Verified on go1.25.11: govulncheck 0 vulnerabilities; golangci-lint v2 0 issues; go build + go test ./... (17 pkgs, 0 fail).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to OPE-196 (#129). Clears the Go-side security debt that needed a toolchain bump.
Why
The scheduled Security Audit's Go job flags 7 Go standard-library vulns (
net/textproto,crypto/x509,html/template,net). These live in Go itself — only a patched toolchain fixes them, and Go 1.24 is EOL, so the fixes exist only in 1.25.x.Changes
Go 1.25:
go.mod:toolchain go1.24.5->go1.25.11ci.yml/security.yml:go-version->1.25Dockerfile:golang:alpine->golang:1.25-alpine(both stages)golangci-lint v2 (forced by the bump): the pinned v1.64.8 is built with go1.24 and refuses go1.25 targets.
golangci-lint-action@v6->@v7;.golangci.ymlmigrated to v2 format (same linter set — v1's enabled list == v2's standard default).stylecheck/quickfixintostaticcheck, surfacing 14 findings, all fixed:ST1005capitalized error strings (opsgenie,teams_service,import_opsgenie)QF1012fmt.Fprintf(&b, …)overb.WriteString(fmt.Sprintf(…))(ai_service,slack_event_handler)QF1003tagged switch (slack_message_builder)Verification (all on go1.25.11)
govulncheck ./...-> 0 vulnerabilitiesgolangci-lint run(v2.12.2) -> 0 issuesgo build ./...+go test ./...-> 17 packages ok, 0 failures (error-string changes broke no tests)After this lands
The scheduled Security Audit goes fully green (Go job clean here; Node job already cleared by #129).
Not in scope (separate)
vite/rollup/esbuild) — major vite bumponly-verifiedtrufflehog inputCloses OPE-197