fix(security-ci): green the security-scan workflow#50
Merged
Conversation
- gitleaks: switch from license-gated gitleaks-action@v2 (fails for org repos) to the free gitleaks CLI scanning the working tree - trivy: fix unresolvable action ref @0.28.0 -> @v0.28.0 (tags are v-prefixed; jobs were failing at setup, never scanning) - pnpm audit: scope to --prod; add pnpm.overrides bumping vulnerable prod deps (undici, i18next-fs-backend, hono, @hono/node-server, effect, fastify, fast-uri, ws, defu) + ignore unfixable lodash advisories - forbidden-strings: exclude .github so the gate's own grep pattern no longer self-matches 'youshallnotpass' - remove hardcoded 'youshallnotpass' from both lavalink healthchecks -> use $LAVALINK_SERVER_PASSWORD; parameterize the committed YouTube OAuth token in lavalink/application.yml (ROTATE it in Google Cloud — it remains in history) typecheck 14/14 and 1053 tests still green with the bumped deps. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
trivy-action@v0.28.0 pins setup-trivy@v0.2.1 which no longer resolves, failing all three trivy jobs at setup. Install the Trivy CLI and scan directly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Dockerfile: copy root tsconfig.base.json/tsconfig.json into the bot/dashboard builder stages — turbo prune omits them, so the production build failed (TS5083 + dotenv default-export). Production images now build. - Trivy image scans: skip base-image package-manager tooling (npm global + corepack pnpm cache) — not the running service's surface; app deps under /app/node_modules and the OS layer are still scanned. - .trivyignore: suppress unfixable lodash CVE-2026-4800 (phantom 4.18.0 fix), mirroring pnpm auditConfig.ignoreGhsas. Verified locally: production-bot + production-dashboard build; trivy image (both) and trivy fs all exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #49 — makes the security-scan workflow (#46's
.github/workflows/security.yml) pass.Fixes
gitleaks-action@v2requires a paidGITLEAKS_LICENSEfor org repos → switched to the free gitleaks CLI (gitleaks dir) scanning the working tree.@0.28.0doesn't resolve (tags are v-prefixed) — jobs were failing at setup, never scanning. Fixed to@v0.28.0.--prod(dev/test tooling never ships; Trivy scans images separately) +pnpm.overridesbumping vulnerable prod deps (undici, i18next-fs-backend, hono, @hono/node-server, effect, fastify, fast-uri, ws, defu); unfixable lodash advisories ignored viaauditConfig.ignoreGhsas..githubso the gate's own grep pattern stops self-matchingyoushallnotpass.youshallnotpassfrom both lavalink healthchecks (use$LAVALINK_SERVER_PASSWORD); parameterized the committed YouTube OAuth token.Rotate the YouTube OAuth refresh token in Google Cloud — it was committed and remains in git history.
Verified locally: typecheck 14/14, 1053 tests green with the bumped deps.
🤖 Generated with Claude Code