feat(rules): searchable pickers across the automation rule builder#52
Merged
Conversation
Extract DiscordSelect's popover-based searchable shell into a reusable SearchableSelect and use it for the trigger event picker. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adds a presentational searchable single-select built on Popover with label+keyword filtering, allowNone row, loading/error states, and Obsidian Engine design tokens. Wires up @testing-library/jest-dom via a vitest setup file so toBeInTheDocument matchers work across all client component tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…/operator/channel/role selects Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace both action-type <Select> pickers (ActionPanel + StepPanel) with SearchableSelect, backed by a new shared buildActionTypeOptions() helper that maps ACTION_ICONS and description as search keywords. Adds i18n keys panel.search and panel.noResults; includes 2 unit tests (TDD RED→GREEN). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Extends SearchableSelect with id/aria-required forwarding for label association, converts ActionFields channel and role <Select> pickers to SearchableSelect, and adds form.search/form.noResults i18n keys to common.json. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds search to every
<Select>picker in the automation rule builder. Introduces one reusable, presentationalSearchableSelect(Popover + auto-focused search + filtered list) and routes all the rule-builder pickers through it.What changed
SearchableSelect(apps/dashboard/src/client/shared/ui/searchable-select.tsx) — data-agnostic searchable single-select lifted from theDiscordSelectshell; supports per-row icons,keywordssearch, loading/error/empty states, and optionalid/aria-requiredfor<Label>association.DiscordSelectrefactored ontoSearchableSelect— public API and appearance unchanged (all 7 existing consumers unaffected).ACTION_ICONS), condition field + operator, and the action-field channel + role pickers. The generic action-field enum select is intentionally left as a plain<Select>.buildActionTypeOptions(unit-tested) maps action-type constants → options.panel.search/panel.noResults(rules) andform.search/form.noResults(common).Testing
tests/clientsuite: 60/60 passing (Docker); client typecheck clean.SearchableSelectbehavior (10),DiscordSelectcharacterization smoke (2),buildActionTypeOptions(2).Notes / follow-ups
@testing-library/jest-dom(+tests/setup.ts+ vitestsetupFiles) for the component tests.pnpm-lock.yamlchanged — rebuild the bot Docker image so in-container installs stop needing--no-frozen-lockfile(CI unaffected; committed lockfile + manifest are consistent).form.noResultswording with the component default.Spec:
docs/superpowers/specs/2026-07-09-searchable-event-picker-design.md· Plan:docs/superpowers/plans/2026-07-09-searchable-event-picker.md🤖 Generated with Claude Code