Clean up compute architecture API#7
Merged
aidankhogg merged 1 commit intoJul 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
computecommons.computeexposes the canonical architecture enum and normalization helpers rather than a placeholder module or duplicate value objects.Description
builds/packages/base/internetworking/src/computecommons/compute/architecture.pythat re-exportsCPUArchitecturefromcomputecommons.enumsandARCHITECTURE_ALIASES/normalize_architecturefromcomputecommons.staticand sets__all__to expose the accepted helpers.builds/packages/base/internetworking/src/computecommons/compute/__init__.pyto import and exportARCHITECTURE_ALIASES,CPUArchitecture, andnormalize_architecturealongside the existing compute models.compute/architechture.pyto avoid duplicate/incorrect package surface before the stable v0.1 release.builds/packages/base/internetworking/tests/test_compute.pyto assert that thecomputepackage re-exports the canonical enum and normalization function and that the module-level helpers match the static implementations.Testing
python -m ruff check tests/test_compute.py src/computecommons/compute/architecture.py src/computecommons/compute/__init__.pyand applied an auto-fix for import formatting, which completed successfully.python -m pytestinbuilds/packages/base/internetworkingand all tests passed (39 passed).python -m mypy src testsand it failed due to pre-existing typing issues intests/test_empty_module_surface.py(unrelated to the architecture changes).Codex Task