fix(workflow): set durations to seconds#1645

Closed

EnkiP wants to merge 217 commits into

mainfrom

fix/set-duration-to-seconds

Commits on Mar 17, 2026

feat(workflow-executor): scaffold @forestadmin/workflow-executor package

matthv
authored and
alban bertolini
committed
feat(workflow-executor): finalize scaffold — clean CLAUDE.md, remove premature deps, add smoke test

alban bertolini
and
claude
committed
fix(workflow-executor): address review — lint test dir, improve test, document system architecture

alban bertolini
and
claude
committed

Commits on Mar 19, 2026

feat(workflow-executor): add ReadRecordStepExecutor (#1497)
Scra3
authored

Commits on Mar 20, 2026

feat(workflow-executor): add HTTP server and WorkflowRunner scaffold (#1500)
matthv
authored

Commits on Mar 24, 2026

Commits on Mar 26, 2026

feat(workflow-executor): add buildInMemoryExecutor and buildDatabaseExecutor factories (#1510)
Scra3
authored

Commits on Mar 27, 2026

feat(workflow-executor): add graceful shutdown with in-flight step drain (#1512)

matthv
and
alban bertolini
authored

Commits on Mar 30, 2026

feat(workflow-executor): add info logging around step execution (#1514)
Scra3
authored

Commits on Mar 31, 2026

Commits on Apr 1, 2026

feat(workflow-executor): add example setup with Docker and buildDatabaseExecutor (#1524)
matthv
authored

Commits on Apr 2, 2026

Commits on Apr 17, 2026

feat(workflow-executor): add server step to StepDefinition mapper

alban bertolini
and
claude
committed
refactor(workflow-executor): fix lint errors in step-definition-mapper

alban bertolini
and
claude
committed
feat(workflow-executor): wire forest server port to real orchestrator routes

alban bertolini
and
claude
committed

Commits on Apr 20, 2026

feat(workflow-executor): wire updateStepExecution to orchestrator route

alban bertolini
and
claude
committed
feat(workflow-executor): wire hasRunAccess to access-check endpoint

alban bertolini
and
claude
committed
feat(workflow-executor): pass runId to getCollectionSchema

alban bertolini
and
claude
committed
fix(workflow-executor): harden port against partial server failures

alban bertolini
and
claude
committed
feat(workflow-executor): add forest-workflow-executor CLI

alban bertolini
and
claude
committed
Merge remote-tracking branch 'origin/main' into feat/prd-214-server-step-mapper
alban bertolini
committed
fix(workflow-executor): unblock build by aligning deps and action endpoints

alban bertolini
and
claude
committed
chore(workflow-executor): flag action-from-front TODO on buildActionEndpoints

alban bertolini
and
claude
committed
chore(workflow-executor): drop inline TODO on buildActionEndpoints

alban bertolini
and
claude
committed
chore(workflow-executor): switch example to the CLI entry point

alban bertolini
and
claude
committed
feat(workflow-executor): log every poll cycle for dev visibility

alban bertolini
and
claude
committed
chore(workflow-executor): turn example/ into a yarn workspace package

alban bertolini
and
claude
committed
fix(workflow-executor): allow ForestServerWorkflowPort logger arg in build tests

alban bertolini
and
claude
committed
feat(agent): proxy workflow executor routes via /_internal/workflow-executions

committed
feat(workflow-executor): colorize CLI logs in TTY, keep JSON in pipes

alban bertolini
and
claude
committed
chore(workflow-executor): silence Sequelize default SQL query logger

alban bertolini
and
claude
committed
test(workflow-executor): assert Poll cycle completed log emits counts

alban bertolini
and
claude
committed
chore(workflow-executor): harden defaults for logger and Sequelize

alban bertolini
and
claude
committed
feat(workflow-executor): probe agent reachability at startup

alban bertolini
and
claude
committed
feat(workflow-executor): harden agent probe per skeptic review

alban bertolini
and
claude
committed
ci: add debug step on build failure to diagnose workspace resolution

alban bertolini
and
claude
committed
ci: remove nested @forestadmin workspace copies before build

alban bertolini
and
claude
committed
test(workflow-executor): cover guidance/mcp outcome mapping and SIGTERM handler

alban bertolini
and
claude
committed
feat(workflow-executor): persist frontend action result + reject form actions

alban bertolini
and
claude
committed
refactor(workflow-executor): skeptic-review fixes on action feature

alban bertolini
and
claude
committed
test(workflow-executor): update integration test for new Branch A behavior

alban bertolini
and
claude
committed

Commits on Apr 21, 2026

refactor(workflow-executor): accept form actions when frontend is in the loop

alban bertolini
and
claude
committed
chore(examples): wire workflow-executor proxy in _example and bump port

alban bertolini
and
claude
committed
chore(_example): drop hardcoded default workflowExecutorUrl

alban bertolini
and
claude
committed
feat(agent): probe workflow-executor reachability at startup

alban bertolini
and
claude
committed
Revert "feat(agent): probe workflow-executor reachability at startup"
alban bertolini
committed
feat(workflow-executor): configurable step execution timeout

alban bertolini
and
claude
committed
refactor(workflow-executor): harden step timeout per review

alban bertolini
and
claude
committed
chore(workflow-executor): align .env.example port with docker-compose (5459)

alban bertolini
and
claude
committed
refactor(workflow-executor): use zod for env var validation

alban bertolini
and
claude
committed
refactor(workflow-executor): rename runWithOptionalTimeout to runWithTimeout

alban bertolini
and
claude
committed
fix(workflow-executor): surface wrapped error messages in logs

alban bertolini
and
claude
committed
chore(workflow-executor): pin docker compose project name

alban bertolini
and
claude
committed
chore(workflow-executor): drop hardcoded container_name

alban bertolini
and
claude
committed
feat(workflow-executor): emit Forest Admin activity logs around each step

alban bertolini
and
claude
committed
refactor(workflow-executor): hardening fixes on activity logs

alban bertolini
and
claude
committed
refactor(workflow-executor): followup wording + test polish on activity logs

alban bertolini
and
claude
committed
feat(workflow-executor): report malformed runs to orchestrator instead of silent skip

alban bertolini
and
claude
committed
fix(workflow-executor): report all WorkflowExecutorError subclasses, not only InvalidStepDefinitionError

alban bertolini
and
claude
committed
refactor(workflow-executor): move malformed-run reporting from port to Runner

alban bertolini
and
claude
committed
refactor(workflow-executor): relocate SafeAgentPort to adapters and inject at composition root

alban bertolini
and
claude
committed
refactor(workflow-executor): stop exporting adapter types and mappers from the public barrel

alban bertolini
and
claude
committed
refactor(workflow-executor): scope forestServerToken to a RunActivityLogger at the Runner boundary

alban bertolini
and
claude
committed
refactor(workflow-executor): inline SafeAgentPort into AgentClientAgentPort

alban bertolini
and
claude
committed
feat(workflow-executor): normalize errors across all ports

alban bertolini
and
claude
committed
chore(workflow-executor): trim verbose JSDoc blocks

alban bertolini
and
claude
committed

Commits on Apr 22, 2026

refactor(workflow-executor): inject ActivityLogPort per-run via a factory

alban bertolini
and
claude
committed
refactor(workflow-executor): apply skeptic-validated fixes on activity log factory

alban bertolini
and
claude
committed
fix(workflow-executor): send collectionId in activity logs; align run envelope with orchestrator

alban bertolini
and
claude
committed
refactor(workflow-executor): apply skeptic-validated fixes on collectionId commit

alban bertolini
and
claude
committed
refactor(workflow-executor): restore run envelope fields the orchestrator still sends

alban bertolini
and
claude
committed
feat(workflow-executor): zod-infer domain types + validate PendingStepExecution post-mapper

alban bertolini
and
claude
committed
refactor(workflow-executor): tighten zod schemas + test end-to-end validation flow

alban bertolini
and
claude
committed
feat(workflow-executor): zod-validate CollectionSchema at the wire boundary

alban bertolini
and
claude
committed
refactor(workflow-executor): use z.looseObject() instead of deprecated .passthrough()

alban bertolini
and
claude
committed
refactor(workflow-executor): rename types/record.ts to types/collection.ts

alban bertolini
and
claude
committed
refactor(workflow-executor): reorganize types into validated/ subfolder

alban bertolini
and
claude
committed
refactor(workflow-executor): move pending-data-validators into http/

alban bertolini
and
claude
committed
Merge remote-tracking branch 'origin/main' into feat/prd-214-server-step-mapper
alban bertolini
committed
test(workflow-executor): add createMcpActivityLog to ActivityLogsService mocks

alban bertolini
and
claude
committed
test(workflow-executor): cover markFailed retry-exhaustion path + mark defensive branches

alban bertolini
and
claude
committed
Merge remote-tracking branch 'origin/main' into feat/prd-214-server-step-mapper
alban bertolini
committed
refactor(workflow-executor): drop encodePk helper — agent-client now accepts composite PKs as arrays

alban bertolini
and
claude
committed

Commits on Apr 23, 2026

feat(workflow-executor): chain auto steps from /update-step response

alban bertolini
and
claude
committed
fix(workflow-executor): report synthetic error outcome on FATAL executor rejection

alban bertolini
and
claude
committed

Commits on Apr 24, 2026

Merge remote-tracking branch 'origin/main' into feat/prd-214-server-step-mapper
alban bertolini
committed
feat(workflow-executor): retry transient failures on orchestrator calls (#1570)
Scra3
authored
feat(workflow-executor): allow user to inject selectedOption on condition step

alban bertolini
and
claude
committed
refactor(workflow-executor): unify user-override and AI paths in ConditionStepExecutor

alban bertolini
and
claude
committed
feat(workflow-executor): write-ahead log idempotency for mutating executors

alban bertolini
and
claude
committed
fix(workflow-executor): fix prettier formatting on idempotency test assertions

alban bertolini
and
claude
committed
chore(workflow-executor): bump agent-client to 1.5.5 and forestadmin-client to 1.39.4

alban bertolini
and
claude
committed

Commits on Apr 27, 2026

feat(workflow-executor): add observability logs for ignored triggers and chain completion

alban bertolini
and
claude
committed
refactor(workflow-executor): rename pending* → available* to align with orchestrator endpoint naming

alban bertolini
and
claude
committed
docs(workflow-executor): update CLAUDE.md stale references after pending→available rename

alban bertolini
and
claude
committed
refactor(workflow-executor): rename run-to-pending-step-mapper → run-to-available-step-mapper

alban bertolini
and
claude
committed
refactor(workflow-executor): remove redundant isRunning flag and fix logger.info optional chaining

alban bertolini
and
claude
committed
refactor(workflow-executor): extract InFlightRunRegistry into its own file

alban bertolini
and
claude
committed
style(workflow-executor): fix prettier formatting

alban bertolini
and
claude
committed

Commits on Apr 28, 2026

docs: update WORKFLOW-EXECUTOR-CONTRACT.md to reflect current implementation

alban bertolini
and
claude
committed
feat(workflow-executor): add MAX_CHAIN_DEPTH env var to CLI

alban bertolini
and
claude
committed
feat(workflow-executor): type-aware Zod schemas in buildUpdateFieldTool (PRD-302)

alban bertolini
and
claude
committed

Commits on Apr 29, 2026

fix(workflow-executor): align collection schema contract with private-api types

alban bertolini
and
claude
committed
fix(workflow-executor): normalize collectionDisplayName null to collectionName

alban bertolini
and
claude
committed
fix(workflow-executor): fallback collectionDisplayName null/empty to collectionName

alban bertolini
and
claude
committed
fix(workflow-executor): address PR review comments

alban bertolini
and
claude
committed
fix(workflow-executor): fix prettier formatting in test

alban bertolini
and
claude
committed
chore(_example): add start:with-executor and db:executor:* scripts

alban bertolini
and
claude
committed
chore(_example): use tsx watch for executor in start:with-executor

alban bertolini
and
claude
committed
feat(workflow-executor): prefix CLI env vars with EXECUTOR_ to avoid collision

alban bertolini
and
claude
committed
revert(workflow-executor): keep AGENT_URL / DATABASE_URL in CLI (no EXECUTOR_ prefix)

alban bertolini
and
claude
committed
fix(_example): keep set -a active when remapping EXECUTOR_ env vars for executor

alban bertolini
and
claude
committed
fix(_example): escape dollar signs so EXECUTOR_ vars expand inside bash, not yarn

alban bertolini
and
claude
committed
fix(_example): replace sleep 5 with agent health-check loop before executor start

alban bertolini
and
claude
committed
feat(workflow-executor): log graceful shutdown start and completion in runner

alban bertolini
and
claude
committed
fix(_example): use exec so SIGTERM reaches tsx/node directly for graceful shutdown

alban bertolini
and
claude
committed
fix(_example): drop tsx watch in favour of tsx for graceful signal handling

alban bertolini
and
claude
committed
revert(_example): restore tsx watch for executor hot-reload

alban bertolini
and
claude
committed

Commits on Apr 30, 2026

chore(_example): clean up .env.example executor vars

alban bertolini
and
claude
committed
fix(agent): rebuild executor URL from params to avoid Koa prefix leaking into proxy path

alban bertolini
and
claude
committed
Revert "fix(agent): rebuild executor URL from params to avoid Koa prefix leaking into proxy path"
alban bertolini
committed
fix: remove /forest prefix from proxy
Enki Pontvianne
committed
fix(agent): rebuild executor URL from params to avoid framework prefix in proxy path

alban bertolini
and
claude
committed
fix(workflow-executor): strip unknown server keys from step-definition schemas

alban bertolini
and
claude
committed
feat(workflow-executor): signal manually handled steps in AI context

alban bertolini
and
claude
committed
fix(workflow-executor): use executionResult absence as manually-handled signal

alban bertolini
and
claude
committed
style(workflow-executor): fix prettier formatting in step-summary-builder test

alban bertolini
and
claude
committed
refactor(workflow-executor): move record-only methods from Base to RecordStepExecutor

alban bertolini
and
claude
committed
fix(workflow-executor): drop errorMessage from activity log status PATCH body

alban bertolini
and
claude
committed
fix(workflow-executor): restore original field names after agent-client camelCase deserialization

alban bertolini
and
claude
committed
fix(workflow-executor): restore field names in getRelatedData recordId and values

alban bertolini
and
claude
committed
refactor(workflow-executor): inline extractRecordId as a one-liner

alban bertolini
and
claude
committed
fix(workflow-executor): restore field names in updateRecord return values

alban bertolini
and
claude
committed

Commits on May 4, 2026

Merge remote-tracking branch 'origin/main' into feat/prd-214-server-step-mapper
alban bertolini
committed
chore(workflow-executor): bump agent-client to 1.5.6 and forestadmin-client to 1.39.5

alban bertolini
and
claude
committed
fix(workflow-executor): guidance step returns awaiting-input when no pending data

alban bertolini
and
claude
committed
style(workflow-executor): use dot notation for guidance schema access

alban bertolini
and
claude
committed
fix(workflow-executor): handle uppercase letters after underscore in restoreFieldNames

alban bertolini
and
claude
committed

Commits on May 5, 2026

fix(workflow-executor): skip sub-workflow steps in previousSteps history

alban bertolini
and
claude
committed
test(workflow-executor): cover all unsupported history step types and rethrow path

alban bertolini
and
claude
committed

Commits on May 6, 2026

fix(workflow-executor): wrap update-record-field tool schema in z.object to fix OpenAI rejection

alban bertolini
and
claude
committed
test(workflow-executor): add regression tests for update-record-field root schema shape

alban bertolini
and
claude
committed

Commits on May 11, 2026

fix(workflow-executor): update integration test mocks to use input wrapper for update-record-field

alban bertolini
and
claude
committed

Commits on May 13, 2026

fix(workflow-executor): skip errored steps (done:false + context.error) when finding pending step

alban bertolini
and
claude
committed
docs(_example): document start:with-executor setup

alban bertolini
and
claude
committed

Commits on May 18, 2026

fix(workflow-executor): use last step from history instead of finding first non-done

alban bertolini
and
claude
committed
fix(workflow-executor): return null when last step is done (completed run)

alban bertolini
and
claude
committed
Merge remote-tracking branch 'origin/main' into feat/prd-214-server-step-mapper
alban bertolini
committed

Commits on May 19, 2026

fix(workflow-executor): tolerate LLM field name variations in findField

alban bertolini
and
claude
committed
refactor(workflow-executor): clarify why findField has a normalized fallback

alban bertolini
and
claude
committed

Commits on May 20, 2026

Commits on May 22, 2026

refactor(workflow-executor): add stepType to all step execution logs (#1592)
Scra3
authored

Commits on May 25, 2026

fix(workflow): replace automatedExecution with executionType (#1590)
EnkiP
authored

Commits on May 26, 2026

Commits on Jun 1, 2026

Commits on Jun 2, 2026

Commits on Jun 3, 2026

Commits on Jun 4, 2026

Commits on Jun 5, 2026

fix(agent-client): serialize fields[] projection as comma-separated string (PRD-437) (#1622)

christophebrun-forest
and
claude
authored

Commits on Jun 8, 2026

Commits on Jun 9, 2026

Commits on Jun 10, 2026

fix(workflow): set durations to seconds
Enki Pontvianne
committed