Make it more clear that test data is fake

test/lib/wire_client/providers/sftp/wire_credit_batch_test.rb

@@ -4,17 +4,17 @@ class SftpProvider
   class WireCreditBatchTest < MiniTest::Test
     def conn_info
       lambda do |host, username, options|
-        assert_equal WireClient::HSBC.host, host
-        assert_equal WireClient::HSBC.username, username
+        assert_equal WireClient::FakeBank.host, host
+        assert_equal WireClient::FakeBank.username, username
         assert_equal ({
-          key_data: [WireClient::HSBC.private_ssh_key],
-          password: WireClient::HSBC.password,
+          key_data: [WireClient::FakeBank.private_ssh_key],
+          password: WireClient::FakeBank.password,
         }), options
       end
     end
 
     def first_credit_batch
-      sample = WireClient::HSBC::WireBatch.new(
+      sample = WireClient::FakeBank::WireBatch.new(
         transaction_type: WireClient::TransactionTypes::Credit
       )
       sample.add_transaction(
@@ -41,15 +41,15 @@ def test_send_first_batch
         assert_includes file_body, "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Document xmlns=\"urn:iso:std:iso:20022:tech:xsd:pain.001.001.03\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"urn:iso:std:iso:20022:tech:xsd:pain.001.001.03 pain.001.001.03.xsd\">"
         assert_includes file_body, "<CreDtTm>2016-08-11"
         assert_includes file_body, "<ChrgBr>DEBT</ChrgBr>"
-        assert_includes file_body, "<Nm>#{WireClient::HSBC::WireBatch.initiator_name}</Nm>"
+        assert_includes file_body, "<Nm>#{WireClient::FakeBank::WireBatch.initiator_name}</Nm>"
         assert_includes file_body, "<PstCd>02115</PstCd>"
         assert_includes file_body, "<AdrLine>1 Nowhere Line</AdrLine>"
         assert_includes file_body, "<TwnNm>Boston</TwnNm>"
         assert_includes file_body, "<CtrySubDvsn>MA</CtrySubDvsn>"
         assert_includes file_body, "<Ctry>US</Ctry>"
-        assert_includes file_body, "<Id>#{WireClient::HSBC::WireBatch.initiator_identifier}</Id>"
-        assert_includes file_body, "<Id>#{WireClient::HSBC::WireBatch.initiator_account_number}</Id>"
-        assert_includes file_body, "<MmbId>#{WireClient::HSBC::WireBatch.initiator_wire_routing_number}</MmbId>"
+        assert_includes file_body, "<Id>#{WireClient::FakeBank::WireBatch.initiator_identifier}</Id>"
+        assert_includes file_body, "<Id>#{WireClient::FakeBank::WireBatch.initiator_account_number}</Id>"
+        assert_includes file_body, "<MmbId>#{WireClient::FakeBank::WireBatch.initiator_wire_routing_number}</MmbId>"
         assert_includes file_body, "<InstdAmt Ccy=\"USD\">102.50</InstdAmt>"
         assert_includes file_body, "<Nm>Some Merchant</Nm>"
         assert_includes file_body, "<Id>3019586020</Id>"
@@ -59,14 +59,14 @@ def test_send_first_batch
     end
 
     def second_credit_batch
-      sample = WireClient::HSBC::WireBatch.new(
+      sample = WireClient::FakeBank::WireBatch.new(
         transaction_type: WireClient::TransactionTypes::Credit
       )
       sample.add_transaction(
         name: 'John Doe from Ohio',
         wire_routing_number: '021000089',
         account_number: '42349053',
-        agent_name: 'HSBC',
+        agent_name: 'FakeBank',
         country: 'US',
         remittance_information: 'Any information about the transaction',
         amount: 202.50
@@ -82,15 +82,15 @@ def test_send_second_batch
         assert_includes file_body, "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Document xmlns=\"urn:iso:std:iso:20022:tech:xsd:pain.001.001.03\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"urn:iso:std:iso:20022:tech:xsd:pain.001.001.03 pain.001.001.03.xsd\">"
         assert_includes file_body, "<CreDtTm>2016-08-11"
         assert_includes file_body, "<ChrgBr>DEBT</ChrgBr>"
-        assert_includes file_body, "<Nm>#{WireClient::HSBC::WireBatch.initiator_name}</Nm>"
+        assert_includes file_body, "<Nm>#{WireClient::FakeBank::WireBatch.initiator_name}</Nm>"
         assert_includes file_body, "<PstCd>NA</PstCd>"
         assert_includes file_body, "<AdrLine>NA</AdrLine>"
         assert_includes file_body, "<TwnNm>NA</TwnNm>"
         assert_includes file_body, "<CtrySubDvsn>MA</CtrySubDvsn>"
         assert_includes file_body, "<Ctry>US</Ctry>"
-        assert_includes file_body, "<Id>#{WireClient::HSBC::WireBatch.initiator_identifier}</Id>"
-        assert_includes file_body, "<Id>#{WireClient::HSBC::WireBatch.initiator_account_number}</Id>"
-        assert_includes file_body, "<MmbId>#{WireClient::HSBC::WireBatch.initiator_wire_routing_number}</MmbId>"
+        assert_includes file_body, "<Id>#{WireClient::FakeBank::WireBatch.initiator_identifier}</Id>"
+        assert_includes file_body, "<Id>#{WireClient::FakeBank::WireBatch.initiator_account_number}</Id>"
+        assert_includes file_body, "<MmbId>#{WireClient::FakeBank::WireBatch.initiator_wire_routing_number}</MmbId>"
         assert_includes file_body, "<InstdAmt Ccy=\"USD\">202.50</InstdAmt>"
         assert_includes file_body, "<Nm>John Doe from Ohio</Nm>"
         assert_includes file_body, "<Id>42349053</Id>"

test/lib/wire_client/providers/sftp/wire_debit_batch_test.rb

@@ -3,7 +3,7 @@
 class SftpProvider
   class WireDebitBatchTest < MiniTest::Test
     def eur_debit_batch
-      sample = WireClient::HSHNordbankHamburg::WireBatch.new(
+      sample = WireClient::OtherFakeBank::WireBatch.new(
         transaction_type: WireClient::TransactionTypes::Debit
       )
       sample.add_transaction(
@@ -24,7 +24,7 @@ def eur_debit_batch
     end
 
     def gbp_debit_batch
-      sample = WireClient::HSHNordbankHamburg::WireBatch.new(
+      sample = WireClient::OtherFakeBank::WireBatch.new(
         transaction_type: WireClient::TransactionTypes::Debit
       )
       sample.add_transaction(
@@ -44,7 +44,7 @@ def gbp_debit_batch
     end
 
     def usd_debit_batch
-      sample = WireClient::HSHNordbankHamburg::WireBatch.new(
+      sample = WireClient::OtherFakeBank::WireBatch.new(
         transaction_type: WireClient::TransactionTypes::Debit
       )
       sample.add_transaction(
@@ -62,11 +62,11 @@ def usd_debit_batch
 
     def conn_info
       lambda do |host, username, options|
-        assert_equal WireClient::HSHNordbankHamburg.host, host
-        assert_equal WireClient::HSHNordbankHamburg.username, username
+        assert_equal WireClient::OtherFakeBank.host, host
+        assert_equal WireClient::OtherFakeBank.username, username
         assert_equal ({
-          key_data: [WireClient::HSHNordbankHamburg.private_ssh_key],
-          password: WireClient::HSHNordbankHamburg.password,
+          key_data: [WireClient::OtherFakeBank.private_ssh_key],
+          password: WireClient::OtherFakeBank.password,
         }), options
       end
     end
@@ -80,7 +80,7 @@ def test_send_eur_batch
         assert_includes file_body, "<CreDtTm>2016-08-11"
         assert_includes file_body, "<ChrgBr>CRED</ChrgBr>"
         assert_includes file_body, "<Nm>Business from Germany</Nm>"
-        assert_includes file_body, "<IBAN>#{WireClient::HSHNordbankHamburg::WireBatch.initiator_iban}</IBAN>"
+        assert_includes file_body, "<IBAN>#{WireClient::OtherFakeBank::WireBatch.initiator_iban}</IBAN>"
         assert_includes file_body, "<InstdAmt Ccy=\"EUR\">102.50</InstdAmt>"
         assert_includes file_body, "<Nm>Zahlemann &amp; Söhne GbR</Nm>"
         assert_includes file_body, "<IBAN>DE21500500009876543210</IBAN>"
@@ -97,7 +97,7 @@ def test_send_gbp_batch
         assert_includes file_body, "<CreDtTm>2016-08-11"
         assert_includes file_body, "<ChrgBr>CRED</ChrgBr>"
         assert_includes file_body, "<Nm>Business from Germany</Nm>"
-        assert_includes file_body, "<IBAN>#{WireClient::HSHNordbankHamburg::WireBatch.initiator_iban}</IBAN>"
+        assert_includes file_body, "<IBAN>#{WireClient::OtherFakeBank::WireBatch.initiator_iban}</IBAN>"
         assert_includes file_body, "<InstdAmt Ccy=\"GBP\">102.50</InstdAmt>"
         assert_includes file_body, "<Nm>UK Corp</Nm>"
         assert_includes file_body, "<IBAN>GB29NWBK60161331926819</IBAN>"
@@ -114,7 +114,7 @@ def test_send_usd_batch
         assert_includes file_body, "<CreDtTm>2016-08-11"
         assert_includes file_body, "<ChrgBr>CRED</ChrgBr>"
         assert_includes file_body, "<Nm>Business from Germany</Nm>"
-        assert_includes file_body, "<IBAN>#{WireClient::HSHNordbankHamburg::WireBatch.initiator_iban}</IBAN>"
+        assert_includes file_body, "<IBAN>#{WireClient::OtherFakeBank::WireBatch.initiator_iban}</IBAN>"
         assert_includes file_body, "<InstdAmt Ccy=\"EUR\">102.50</InstdAmt>"
         assert_includes file_body, "<Nm>Zahlemann &amp; Söhne GbR</Nm>"
         assert_includes file_body, "<IBAN>DE21500500009876543210</IBAN>"

test/test_helper.rb

@@ -50,68 +50,68 @@ def refute_invalid_values(klass, values:, attributes:)
 end
 
 # Configure test settings
-WireClient::HSBC::WireBatch.initiator_name = 'Forward Financing LLC'
-WireClient::HSBC::WireBatch.initiator_wire_routing_number = '021001088'
-WireClient::HSBC::WireBatch.initiator_account_number = '927407619'
-WireClient::HSBC::WireBatch.initiator_identifier = 'FORWARDFINANCINGID'
-WireClient::HSBC::WireBatch.initiator_country = 'US'
-WireClient::HSBC::WireBatch.initiator_country_subdivision = 'MA'
-WireClient::HSBC::WireBatch.initiator_postal_code = '02116'
-WireClient::HSBC::WireBatch.initiator_address_line = '99 Unknown Sidewalk'
-WireClient::HSBC::WireBatch.initiator_city = 'Boston'
+WireClient::FakeBank::WireBatch.initiator_name = 'Forward Financing LLC'
+WireClient::FakeBank::WireBatch.initiator_wire_routing_number = '123456789'
+WireClient::FakeBank::WireBatch.initiator_account_number = '987654321'
+WireClient::FakeBank::WireBatch.initiator_identifier = 'FORWARDFINANCINGID'
+WireClient::FakeBank::WireBatch.initiator_country = 'US'
+WireClient::FakeBank::WireBatch.initiator_country_subdivision = 'MA'
+WireClient::FakeBank::WireBatch.initiator_postal_code = '02116'
+WireClient::FakeBank::WireBatch.initiator_address_line = '99 Unknown Sidewalk'
+WireClient::FakeBank::WireBatch.initiator_city = 'Boston'
 
-WireClient::HSBC.host = 'localhost:3000'
-WireClient::HSBC.username = 'HSBCTester'
-WireClient::HSBC.password = 'HSBCAviatoRulez7'
-WireClient::HSBC.private_ssh_key = "-----BEGIN RSA PRIVATE KEY-----
+WireClient::FakeBank.host = 'localhost:3000'
+WireClient::FakeBank.username = 'FakeBankTest'
+WireClient::FakeBank.password = 'FakeBankTestPassword'
+WireClient::FakeBank.private_ssh_key = "-----BEGIN RSA PRIVATE KEY-----
 MIICWwIBAAKBgQCSNnQuvjgxxXMLSCwOUHiRUuJax2n5RETzQEdlt+qz0v2vmOqY
 KOxPWRTu3qApIOgpoUUJ2QELNWD6b9wIB8Py6Op7Jxp/3kvHpfpsOFxZ5if7MALG
 +OFMmjNzjjAzcs833We1Qlmsq/0mOZQPj5CrnxgQIRF1IyD07hyW7fwmZQIDAQAB
 AoGAfgiKZbB6aAy3ekYgE8ax5zL3AyFZ7BA5DyWdZcT/fzqkirTZo4fDCzLSpIUq
 sck31oq5JB/2kl7U1YuOsy1eba6QvWjm3STsIVMZZSRAlveCZXP1St7VO6EpYp1u
-joUS/R6ZvrQMKjfoJSgg8aLencKKI4HoPPfMU/MOxHm4sgECQQD/F7sgIapa4+Fu
+joUS/R6ZvrQMKjfoJSgg8aLencKKI4aoPPfMU/MOxHm4sgECQQD/F7sgIapa4+Fu
 7Rmsg4szoCc5EWRM6HaXZYG/mq8yzKXcIv07rK0m3oRmPl24N8AaFHiWHoXIgDC9
 ALXw1g1hAkEAkruVqIOHR8zfIY9TBznS4leNiFvrggJAJg5LZK8X36SXwxBF6XFj
 V5NFZcAyoWuD0BgjWhlsLDND/HUUz2kThQJAAhgVxyu/lENupFR583qY9/GGoOdN
-pXv7DT8eE46XhZk8e1QmNAk02q7U82nrpwl+IDiuzLyvaHf07nhFBhcbwQJATlAz
+pXv7DT8eE46dhZk8e1QmNAk02q7U82crpwl+IDiuzLyvaHf07nhFBhcbwQJATlAz
 5gadEyMzC9RU+gxQk2ErNtXocjEFT8pdTtVspn5QSVnMFnXgEYOWjGHyI9kgNtZL
-N/FNnKGX7YwHmVN5iQJAP/neHXHkGnAOKubNcKceiN6CsgpMJwljuRAYUCXyqR5F
+N/FNnKGX7YwHmVN5iQJAP/neHXHkGnbOKubNcKceiN6CsgpMJwljuRAYUCXyqR5F
 RyA0Apd7gmXpC2guaLTvDzpo9d8iR5MKDw6cYUyQsg==
 -----END RSA PRIVATE KEY-----"
-WireClient::HSBC.outgoing_path = '/root/wire_sandbox'
-WireClient::HSBC.outgoing_path = '/root/wire_sandbox/Inbox'
-WireClient::HSBC.file_naming_strategy = lambda do |batch_number|
+WireClient::FakeBank.outgoing_path = '/root/wire_sandbox'
+WireClient::FakeBank.outgoing_path = '/root/wire_sandbox/Inbox'
+WireClient::FakeBank.file_naming_strategy = lambda do |batch_number|
   batch_number ||= 1
   "WIRE#{Date.today.strftime('%m%d%y')}#{batch_number.to_s.rjust(2, '0')}.xml"
 end
 
-WireClient::HSHNordbankHamburg::WireBatch.initiator_name = 'Business from Germany'
-WireClient::HSHNordbankHamburg::WireBatch.initiator_bic = 'HSHNDEHHXXX'
-WireClient::HSHNordbankHamburg::WireBatch.initiator_iban = 'DE87200500001234567890'
-WireClient::HSHNordbankHamburg::WireBatch.initiator_identifier = 'DE98ZZZ09999999999'
-WireClient::HSHNordbankHamburg::WireBatch.initiator_country = 'DE'
+WireClient::OtherFakeBank::WireBatch.initiator_name = 'Fake Business'
+WireClient::OtherFakeBank::WireBatch.initiator_bic = 'FAKEBANKBIC'
+WireClient::OtherFakeBank::WireBatch.initiator_iban = 'US12345678912345678912'
+WireClient::OtherFakeBank::WireBatch.initiator_identifier = 'US99ZZZ99999999999'
+WireClient::OtherFakeBank::WireBatch.initiator_country = 'US'
 
-WireClient::HSHNordbankHamburg.host = 'localhost:3000'
-WireClient::HSHNordbankHamburg.username = 'HSHNordbankHamburgTester'
-WireClient::HSHNordbankHamburg.password = 'HSHNordbankHamburgAviatoRulez7'
-WireClient::HSHNordbankHamburg.private_ssh_key = "-----BEGIN RSA PRIVATE KEY-----
+WireClient::OtherFakeBank.host = 'localhost:3000'
+WireClient::OtherFakeBank.username = 'OtherFakeBank'
+WireClient::OtherFakeBank.password = 'OtherFakeBankPassword'
+WireClient::OtherFakeBank.private_ssh_key = "-----BEGIN RSA PRIVATE KEY-----
 MIICWwIBAAKBgH6s2p8X692q+d4kD6HhhagudbBoxiRFOGQT1x36pu7YpozP7fj2
 u1hDPZ7QOPvlB4KHk8P2eUNxt6sSmWXxc8FOk4TmLMAzkzdk/pi6zkIM3nriOsbm
 lGa36y5tIYbW8zmliw2sGB8/YeB635ioBPUVu689NsIjUjpsx0WOW8EtAgMBAAEC
 gYA20oIvNkAbCCLpc7vcOGkK10iR11ZhXh/AmCGSVOcoGVVDPb3k8Is18Kvbbowq
 3/z3DcvylFn4yV9Ox1biGrQYhCCmxcPWCV7aJ53gCgUdlHvdiBoXjEo5Gz70J6NW
 pv7uxZosnt6nd9ACYg/OO4g052pluTKyAv4mLUx4XoejVQJBAO01GnytrHV0qLTH
-kQEp0IUL3Di50G1zJd4jjml+97uFBMqCCgCNvev1p285mA6p3TkBrURXcPjaI4pR
+kQEp0IUL3Di50G1zJd4jjml+97uFBMqCCgCNvev1p285mA6p3123rURXcPjaI4pR
 BhUxEUsCQQCItgDcMPpw/EpgY9+pD3wMna7dIo49QSf2U/bbA6W7X0eiMOElVTJl
 c7sGqhs/0xQu3jonFLP5gKBVzB0hReRnAkAr8oC7xLmE8V4oUCkPXB3j6HSeld6F
-yKWlaFUEOp/PQC/JDRqpS5l6VAL3WmZPoSz5WNQvKzwk/tVC1QwZdQPNAkAJdtge
+yKWlaFUEOp/PQC/JDRqpS5l6abc3WmZPoSz5WNQvKzwk/tVC1QwZdQPNAkAJdtge
 ZkGgOscHX0KnmIvU78GgS3kfYnhaxDtNtDXv/8ucvdeIVxqTDW0ALByQ0ZMPH5FV
 DUjcV/xBlEzb9dO3AkEA2JLfE998lka8emp/jwmLpnFc2EjWwGIEDHxVNeSNdd0U
-guSskdloMQfuKT+RQ0VBi6V7vZAmL/OQ/jtxG9HNrA==
+guSskdloMQfuKT+RQ0VBi6V7vZawL/OQ/jtxG9HNrA==
 -----END RSA PRIVATE KEY-----"
-WireClient::HSHNordbankHamburg.outgoing_path = '/root/wire_sandbox'
-WireClient::HSHNordbankHamburg.outgoing_path = '/root/wire_sandbox/Inbox'
-WireClient::HSHNordbankHamburg.file_naming_strategy = lambda do |batch_number|
+WireClient::OtherFakeBank.outgoing_path = '/root/wire_sandbox'
+WireClient::OtherFakeBank.outgoing_path = '/root/wire_sandbox/Inbox'
+WireClient::OtherFakeBank.file_naming_strategy = lambda do |batch_number|
   batch_number ||= 1
   "WIRE#{Date.today.strftime('%m%d%y')}#{batch_number.to_s.rjust(2, '0')}.xml"
 end