feat(contract): add multi-sig guardian validation for payout#871
Open
DavidAkere204 wants to merge 1 commit into
Open
feat(contract): add multi-sig guardian validation for payout#871DavidAkere204 wants to merge 1 commit into
DavidAkere204 wants to merge 1 commit into
Conversation
- Add guardians list and guardian_threshold fields to Plan struct - Add GuardianApprovals(Address) variant to DataKey for per-plan storage - Add approve_payout() function: validates caller is a listed guardian, prevents duplicate approvals, persists approvals, emits guardian/approved event - Update trigger_payout() to reject with GuardianThresholdNotMet when approvals count < guardian_threshold (skipped when threshold is 0) - Add NotAGuardian, AlreadyApproved, GuardianThresholdNotMet errors - Update create_plan() to accept guardians and guardian_threshold params - Add 4 new tests: 2-of-3 approval flow, duplicate rejection, non-guardian rejection, and zero-guardian passthrough Closes Fracverse#840
|
@DavidAkere204 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@DavidAkere204 and clippy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #840