Feat/edit inheritance plan 794#876
Merged
ONEONUORA merged 6 commits intoJun 27, 2026
Merged
Conversation
Adds Beneficiary and UpdatePlanRequest interfaces to the Plans API, and a new updatePlan() method that calls PUT /api/plans/:id. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Supports the edit plan flow in unit and integration tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Builds the edit panel for inheritance plan owners with: - Pre-populated fields from current plan state - Add/remove beneficiary rows with wallet address and name - Per-beneficiary percentage allocation with live 100% validation - Inactivity timer configuration (days) - Yield harvesting enable/disable toggle - Save button that requests a Stellar wallet signature (signTransaction) before calling PUT /api/plans/:id, with idle/signing/saving/success/error states Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Server-side page that loads plan data and renders the EditInheritancePlanPanel. Handles loading skeleton and error states. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
14 component tests covering render, pre-population, beneficiary CRUD, allocation validation, yield toggle, save/error flows, and wallet signing. 3 API tests covering successful update, 404 and 500 error handling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@tech-adrian Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
The `text=InheritX` locator matched 6 elements, causing Playwright strict mode to fail. Replaced with `getByRole("banner")` which uniquely targets the header element.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ONEONUORA
approved these changes
Jun 27, 2026
ONEONUORA
left a comment
ONEONUORA
left a comment
Contributor
There was a problem hiding this comment.
Great job @tech-adrian
Thank you for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditInheritancePlanPanel— a modal panel for editing an existing inheritance plankit.signTransaction) then callsPUT /api/plans/:id; shows idle → signing → saving → success/error states/asset-owner/plans/[planId]/editrenders the panel with a loading skeleton and error stateupdatePlan()method added toPlansAPI; MSW handler added forPUT /api/plans/:idTest plan
npm test— 154 tests passtsc --noEmit— no errorsCloses #794
🤖 Generated with Claude Code