Fix Disable Channel Links in Channel Sidenav Menu

[ozrendev]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

relates to #8502

Description

These links were missed in the original PR, so this disables them as originally intended

Testing

Go to Settings -> Parental Control -> Enabled "Disable Channel Link on Videos"
Go to Channels sidenav item, see links are disabled for Channel thumbnail and name

[PikachuEXE]

Should we also disable the icons on side bar? (PR disable channel links in Channel List

[ozrendev]

Should we also disable the icons on side bar? (PR disable channel links in Channel List

Yes, good catch! Added that now

[efb4f5ff-1298-471a-8973-3d47447115dc]

Umm i dont know if thats really necessary as there is already a setting to hide them. Making them non functional feels not logical to me but ofcourse my feeling could be wrong here

[PikachuEXE]

Well my reason would be the existing setting is under "distraction free" not parental control
And we should provide less surprise for users ("what? I need 2 settings to do what I want?
Now whether those sidebar icons should be displayed at all when the new setting is enabled is something else (I have no idea

[efb4f5ff-1298-471a-8973-3d47447115dc]

I guess you're right. I didnt put myself in users shoes enough

[efb4f5ff-1298-471a-8973-3d47447115dc]

should the hover and click animation be disabled too here?

VirtualBoxVM_X4RSr56cFA.mp4

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[PikachuEXE]

should the hover and click animation be disabled too here?

ya