Bump shaka-player from 5.1.12 to 5.2.2 - #9487
Conversation
dependabot
Bot
added
PR: dependencies
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
f734864 to
1b42b41
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
1b42b41 to
68885a8
Compare
|
@dependabot rebase |
Bumps [shaka-player](https://github.com/shaka-project/shaka-player) from 5.1.12 to 5.2.2. - [Release notes](https://github.com/shaka-project/shaka-player/releases) - [Changelog](https://github.com/shaka-project/shaka-player/blob/v5.2.2/CHANGELOG.md) - [Commits](shaka-project/shaka-player@v5.1.12...v5.2.2) --- updated-dependencies: - dependency-name: shaka-player dependency-version: 5.2.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
68885a8 to
7fc27fc
Compare
There was a problem hiding this comment.
I have pushed various changes to support shaka-player 5.2.x but there is still the open question about what we should do with the playback rates menu. shaka-player 5.2.0 redesigned to the playback rates menu from a simple menu to a slider with a few presets, like on YouTube, unfortunately our existing playback rate settings don't work well for the new presets display, as shown in the screenshot below. Also worth noting that while I have wired up our playback rate interval into the slider minimum and our maximium playback rate into the slider maximum, shaka-player does not allow the slider interval to be configured (hardcoded to 0.05), I do not want to open a feature request for it before we have decided what to do about the presets as that could require us to change our settings.
Please leave comments with your ideas and opinions.
Interval set to 0.1x and the max set to 10x
0.25 (Looks better but not good enough I use MPC-HC on windows (I don't have access now Update 1Youtube one doesn't have that many pills and not showing commas (no idea why shaka one is coded to show commas) Update 2Testing code to reduce no. of pills 
Update 3MPC-HC preset shortcuts/"pills" (No change regardless of settings, there is only a setting for interval when changed via keyboard |
|
Played around with allot of settings in the PR and i think the slider should show results based on max playback speed and interval. Pills should be a hardcoded list no matter what the user changes in their settings. Maybe only should see a change when max playback speed is lower then whats in the list so that should be filtered out then Edit: Seems like YT is also doing this but with way less options. I want to avoid adding more complexity |
|
A newer version of shaka-player exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
3 participants
Bumps shaka-player from 5.1.12 to 5.2.2.
Release notes
Sourced from shaka-player's releases.
... (truncated)
Changelog
Sourced from shaka-player's changelog.
... (truncated)
Commits
646f8a4chore(v5.2.x): release 5.2.2 (#10379)d00114ffix(MSF): Report bandwidth per group so ABR can pick higher qualities (#10371)4c89aedfix(security): prevent glob expansion in shaka-bot comment command parser (#1...2bc9d47fix: Fix duplicate error code 4058 (#10372)562425bfix(Transmux): Fall back to main thread when the transmux worker fails (#10370)b48d560fix(MSF): Fix draft-16 negotiation and skip empty catalog objects (#10367)7b38c30ci(release): Suppress patch release PRs on main (#10369)bc3f54fchore(Demo): Remove "moqtail HDR" asset (#10368)14dc58efix(UI): Fix context menu and rate slider touch behavior on mobile (#10365)4e742fdfix: Prevent screen.orientation methods from being garbage collected on Safar...