Skip to content

Add button to collapse playlist when watching a video - #9504

Open
caetano-dev wants to merge 6 commits into
FreeTubeApp:developmentfrom
caetano-dev:feat/collapsePlaylist
Open

Add button to collapse playlist when watching a video#9504
caetano-dev wants to merge 6 commits into
FreeTubeApp:developmentfrom
caetano-dev:feat/collapsePlaylist

Conversation

@caetano-dev

@caetano-dev caetano-dev commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Feature Implementation

Related issue

Closes #1356

Description

Add a button to collapse the playlist when watching a video.

Screenshots

Capture d’écran 2026-07-26 à 15 23 58 Capture d’écran 2026-07-26 à 15 24 05 Capture d’écran 2026-07-26 à 15 24 22 Capture d’écran 2026-07-26 à 15 24 27 Capture d’écran 2026-07-26 à 15 34 23 Capture d’écran 2026-07-26 à 15 34 20

Testing

  1. Go to a playlist
  2. Click on a video
  3. Click on the button to collapse the playlist

Desktop

  • OS: MacOS
  • OS Version: 26
  • FreeTube version: v0.25.1 Beta

@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 26, 2026
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 26, 2026 18:36
@PikachuEXE

PikachuEXE commented Jul 27, 2026

Copy link
Copy Markdown
Member

Can we also make margin-inline 0 when window is narrow?
It's just so obvious when collapsed (see 5th screenshot above
image

Also might be good to add a bit more spacing to the top (3px > 8px
Again the lack spacing become more obvious when a button is added
image
image

@efb4f5ff-1298-471a-8973-3d47447115dc

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 27, 2026

Copy link
Copy Markdown
Member

So normally when the user goes to the next video, the video that is currently playing will be at the top of the list. When i collapse the playlist, go to the next video and expand the playlist it wont list the current video at the top.

VirtualBoxVM_7te2oOh579.mp4

auto-merge was automatically disabled July 27, 2026 23:32

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 23:32
auto-merge was automatically disabled July 27, 2026 23:42

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 23:42
@caetano-dev

caetano-dev commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

CSS changes and playlist sorting fix applied.
@PikachuEXE I am not really sure if I understood what you mentioned about missing spacing at the top, but I increased the padding above the title.

Capture d’écran 2026-07-27 à 20 43 26 Capture d’écran 2026-07-27 à 20 43 39 Capture d’écran 2026-07-27 à 20 43 56

PikachuEXE
PikachuEXE requested changes Jul 28, 2026
View reviewed changes

@PikachuEXE PikachuEXE left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vertical spacing need to be applied to the box so that the new button don't stay too close to the top

Comment thread src/renderer/components/WatchVideoPlaylist/WatchVideoPlaylist.css Outdated
Comment thread src/renderer/components/WatchVideoPlaylist/WatchVideoPlaylist.css
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 28, 2026
auto-merge was automatically disabled July 29, 2026 00:10

Head branch was pushed to by a user without write access

@caetano-dev

caetano-dev commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Suggestions applied.

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 29, 2026 00:11
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

PR: waiting for review For PRs that are complete, tested, and ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fold in playlist list

3 participants

@caetano-dev @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc