Skip to content

Feat: Add SponsorBlock channels exclusion list - #9508

Open
Shadorc wants to merge 13 commits into
FreeTubeApp:developmentfrom
Shadorc:feat/sponsorblock-allowlist
Open

Feat: Add SponsorBlock channels exclusion list#9508
Shadorc wants to merge 13 commits into
FreeTubeApp:developmentfrom
Shadorc:feat/sponsorblock-allowlist

Conversation

@Shadorc

@Shadorc Shadorc commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #4991

Description

Add an exclusion list setting for SponsorBlock which works the same as the 'Hide Channel' setting.

Screenshots

image image

Testing

  1. Go to Settings > SponsorBlock and disable SponsorBlock
  2. Go to any video with sponsor segments
  3. Check that SponsorBlock is not enabled (watch progress shouldn't display any sponsor segments and the video should play entirely)
  4. Go to Trending and check that the dropdown menu on any video does not have the option "Exclude Channel from SponsorBlock"
  5. Go to Settings > SponsorBlock and enable SponsorBlock
  6. Go to any video with sponsor segments
  7. Check that SponsorBlock is enabled (watch progress should display sponsor segments and the video should skip those segments)
  8. Go to Trending and check that the dropdown menu on any video has the option "Exclude Channel from SponsorBlock"
  9. Go to Settings > SponsorBlock and add a channel to Excluded Channels
  10. Check that the channel appears in the added item
  11. Check that Show Added Items toggle works as expected
  12. Go to any video from the excluded channel with sponsor segments
  13. Check that SponsorBlock is not enabled (watch progress shouldn't display any sponsor segments and the video should play entirely)

Desktop

  • OS: bazzite
  • OS Version:
  • FreeTube version: v0.25.1-beta

@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 26, 2026
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 26, 2026 23:18
auto-merge was automatically disabled July 26, 2026 23:41

Head branch was pushed to by a user without write access

@Shadorc
Shadorc force-pushed the feat/sponsorblock-allowlist branch from c9635ea to c010997 Compare July 26, 2026 23:41
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 26, 2026 23:42

@PikachuEXE PikachuEXE left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The new action is in different category from Hide/Show Channel, please add separator
  2. The actual meaning is "channels excluded from SponsorBlock" or "channels with SponsorBlock disabled" or "SponsorBlock disabled channels" not "allowed by SponsorBlock". So the actions should be something like "Exclude channel from SponsorBlock" / "Disable SponsorBlock on channel"

Comment thread static/locales/en-US.yaml Outdated
Comment thread static/locales/en-US.yaml Outdated
auto-merge was automatically disabled July 27, 2026 09:28

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 09:28
auto-merge was automatically disabled July 27, 2026 10:46

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 10:46
auto-merge was automatically disabled July 27, 2026 10:51

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 10:51
auto-merge was automatically disabled July 27, 2026 10:53

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 10:53
auto-merge was automatically disabled July 27, 2026 10:54

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 10:54
@Shadorc

Shadorc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@PikachuEXE Thanks for your suggestions. I was not happy with allow/disallow but I didn't think about include/exclude

Also I've added a non-suggested change: the dropdown option is not added anymore if sponsor block is disabled.

auto-merge was automatically disabled July 27, 2026 11:00

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 11:00
auto-merge was automatically disabled July 27, 2026 11:04

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 11:04
auto-merge was automatically disabled July 27, 2026 11:11

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 27, 2026 11:11
@Shadorc

This comment was marked as resolved.

@Shadorc Shadorc changed the title Feat: Add allowlist of channels from SponsorBlock skips Feat: Add SponsorBlock channels exclusion list Jul 27, 2026
Comment thread static/locales/en-US.yaml Outdated
Comment thread src/renderer/store/modules/settings.js Outdated
auto-merge was automatically disabled July 28, 2026 08:10

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 28, 2026 08:10
auto-merge was automatically disabled July 28, 2026 09:20

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 28, 2026 09:21
@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

This copies the behavior from Hide Channel of not showing the entry on the Subscription page. I would argue that this needs to be shown on the Subscriptions page.

The Hide Channel entry was excluded from the Subscriptions page as it didnt really made any sense to block a channel you are subscribed to. On the other hand its totally possible that the user is subscribed to certain channels they dont mind watching the SP segments

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 28, 2026
auto-merge was automatically disabled July 28, 2026 14:53

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 28, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow whitelisting of channels from Sponsorblock skips

3 participants