Feat: Add SponsorBlock channels exclusion list - #9508
Conversation
Head branch was pushed to by a user without write access
c9635ea to
c010997
Compare
PikachuEXE
left a comment
There was a problem hiding this comment.
- The new action is in different category from Hide/Show Channel, please add separator
- The actual meaning is "channels excluded from SponsorBlock" or "channels with SponsorBlock disabled" or "SponsorBlock disabled channels" not "allowed by SponsorBlock". So the actions should be something like "Exclude channel from SponsorBlock" / "Disable SponsorBlock on channel"
… sponsorblock is disabled
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
@PikachuEXE Thanks for your suggestions. I was not happy with allow/disallow but I didn't think about include/exclude Also I've added a non-suggested change: the dropdown option is not added anymore if sponsor block is disabled. |
…ng 'useSponsorBlock' behaviour
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
… newly added entry
Head branch was pushed to by a user without write access
This comment was marked as resolved.
This comment was marked as resolved.
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
This copies the behavior from Hide Channel of not showing the entry on the Subscription page. I would argue that this needs to be shown on the Subscriptions page. The Hide Channel entry was excluded from the Subscriptions page as it didnt really made any sense to block a channel you are subscribed to. On the other hand its totally possible that the user is subscribed to certain channels they dont mind watching the SP segments |
Head branch was pushed to by a user without write access
Pull Request Type
Related issue
closes #4991
Description
Add an exclusion list setting for SponsorBlock which works the same as the 'Hide Channel' setting.
Screenshots
Testing
Settings > SponsorBlockand disable SponsorBlockTrendingand check that the dropdown menu on any video does not have the option "Exclude Channel from SponsorBlock"Settings > SponsorBlockand enable SponsorBlockTrendingand check that the dropdown menu on any video has the option "Exclude Channel from SponsorBlock"Settings > SponsorBlockand add a channel toExcluded ChannelsShow Added Itemstoggle works as expectedDesktop